Experimental Video Reader Refactoring and API Improvements #5839
+1,350
−1,133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mestamps Signed-off-by: Joaquin Anton Guirao <[email protected]>
jantonguirao
force-pushed
the
simplify_video_loader
branch
from
05541b1 to
a07b96e
Compare
Signed-off-by: Joaquin Anton Guirao <[email protected]>
jantonguirao
force-pushed
the
simplify_video_loader
branch
from
a07b96e to
79ef26d
Compare
jantonguirao
commented
Mar 5, 2025
| file.frame_count_ = av_rescale_q(duration, | ||
| stream->time_base, | ||
| file.frame_base_); | ||
| file.frame_count_ = stream->nb_frames; |
There was a problem hiding this comment.
this is more accurate so using it if available
jantonguirao
changed the title
jantonguirao
force-pushed
the
simplify_video_loader
branch
from
f1ad340 to
05aadd5
Compare
|
!build |
|
CI MESSAGE: [24949282]: BUILD STARTED |
|
CI MESSAGE: [24949282]: BUILD FAILED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
jantonguirao
force-pushed
the
simplify_video_loader
branch
from
05aadd5 to
380a2d7
Compare
|
CI MESSAGE: [24951139]: BUILD STARTED |
|
CI MESSAGE: [24951139]: BUILD FAILED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
|
CI MESSAGE: [25008498]: BUILD STARTED |
|
CI MESSAGE: [25008498]: BUILD FAILED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
|
CI MESSAGE: [25055285]: BUILD STARTED |
|
CI MESSAGE: [25055285]: BUILD FAILED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
jantonguirao
force-pushed
the
simplify_video_loader
branch
from
7c63e66 to
081121a
Compare
|
!build |
|
CI MESSAGE: [25154741]: BUILD STARTED |
Signed-off-by: Joaquin Anton Guirao <[email protected]>
Signed-off-by: Joaquin Anton Guirao <[email protected]>
|
CI MESSAGE: [25159683]: BUILD STARTED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring / New feature
Description:
file_root,file_listmodes tofn.experimental.readers.video, similar to what's available in the legacy decoderframe_index: Frame-based seekingtimestamp: Time-based seeking (non-inclusive)timestamp_inclusive: Time-based seeking (inclusive)file_list_formatoption replaces the legacy operator's boolean flagsfile_list_frame_numandfile_list_include_preceding_frameMisc:
FramesDecoderGpuandFramesDecoderCpuoverridespecifiers for virtual functionsvideo_reader_utils.hheaderAdditional information:
Affected modules and functionalities:
fn.readers.video,fn.experimental.readers.videoKey points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A