Minor fix

[naoyam]

ThreadPredicateMap is now used outside of lowering, so it can't assume GpuLower::current() is available. Hit an assertion error while testing #5278

[naoyam]

!test --diff

[github-actions]

Review updated until commit 0a1a7de

Description

• Fixed assertion error when GpuLower::current() is unavailable

• Made ThreadPredicateMap usable outside of lowering context

• Improved code clarity with updated comments and TODO note

• Initialized stride using fusion's oneVal safely

---

Changes walkthrough 📝

Relevant files

Bug fix

thread_predicate.cpp Remove GpuLower::current dependency and harden logic          csrc/device_lower/analysis/thread_predicate.cpp Replaced GpuLower::current()->kernel()->oneVal() with safer fusion-based access Added non-empty check for merged_logical_domains using NVF_ERROR Updated comments to clarify function purpose and future improvements Added TODO about optimizing predicate generation preparation +10/-2

---

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests

⚡ Recommended focus areas for review Possible Issue The function getIndexOfBroadcastLogicalDomains now uses merged_logical_domains.front()->fusion()->oneVal() instead of GpuLower::current()->kernel()->oneVal(). This change assumes that merged_logical_domains is non-empty, enforced by NVF_ERROR. However, the error check should be placed earlier to ensure safety, especially since this function may be used in contexts where the input vector could be empty. NVF_ERROR(!merged_logical_domains.empty()); logical_stride.at(ndim - 1) = merged_logical_domains.front()->fusion()->oneVal();

[jjsjann123]

code change looks straightforward.

Asking some question about the context, but shouldn't block the PR going in.

[jjsjann123]

This function is currently called no matter if it's just for the analysis but should be lazily done.

I don't follow that comment. This function doesn't seem to be messing with predicates in my monkey eyes.

[naoyam]

Updated the comment. Hopefully it's clearer.

[naoyam]

!build