Skip to content

Greedy scheduler rejects resize to broadcast #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

Greedy scheduler rejects resize to broadcast #5318

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c00e87
Greedy scheduler rejects resize to broadcast
naoyam Oct 3, 2025
93c916b
some more details
naoyam Oct 10, 2025
7a19d51
Merge branch 'main' into greedy_pad_static_check
naoyam Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions csrc/scheduler/greedy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,23 @@ class CompileTimeChecker : private IterVisitor {
void handle(PadOp* pad) override {
checkDomainConstraints(
ir_utils::getTvOutput(pad)->getLogicalDomain(), pad->getPaddedAxes());

for (const auto& logical_id :
ir_utils::getTvOutput(pad)->getLogicalDomain()) {
auto resize = dynamic_cast<Resize*>(logical_id->definition());
if (resize == nullptr) {
continue;
}
// Resize to broadcast not supported yet. Have not looked at
// details but getLoopPromotion fails at csrc/id_model/utils.h:105 (e.g.,
// ResizeTest.ResizePadToBroadcastStatic), likely because
// broadcast IDs are introduced without BroadcastOp.
// This is also the case with the resize scheduler.
if (resize->out()->isBroadcast()) {
reject("Resize to a broadcast ID is not allowed: ", pad->toString());
return;
}
}
}

void handle(TopKOp* topk) override {
Expand Down