-
Notifications
You must be signed in to change notification settings - Fork 73
Enable TensorIndexer with all C++ tests #5724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!test |
|
Review updated until commit 2d73448 Description
|
| Relevant files | |||
|---|---|---|---|
| Enhancement |
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| ⚡ Recommended focus areas for review |
Feature Enablement Impact
|
|
!test |
|
!test |
jjsjann123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 Yay~~
Many of the C++ tests use the new indexer already. I have not checked the remaining ones, but I feel I've done enough due diligence.
This PR enables the new indexer with all the C++ tests. Next steps will be enabling it with the Python tests.