Skip to content

Use toPolymorphicValue to convert py::handle directly to PolymorphicValue #5771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdspring1 merged 2 commits into from
Jan 10, 2026
Merged

Use toPolymorphicValue to convert py::handle directly to PolymorphicValue #5771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27bc164
Use toPolymorphicValue to convert py::handle directly to polymorphic …
rdspring1 Jan 7, 2026
a49a6c1
fix complex
rdspring1 Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions python/python_direct/direct_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@

namespace nvfuser::python {

namespace {

PolymorphicValue toPolymorphicValue(const py::handle& obj) {
static py::object torch_Tensor = py::module_::import("torch").attr("Tensor");
if (py::isinstance(obj, torch_Tensor)) {
return PolymorphicValue(py::cast<at::Tensor>(obj));
} else if (py::isinstance<py::bool_>(obj)) {
return PolymorphicValue(py::cast<bool>(obj));
} else if (py::isinstance<py::int_>(obj)) {
return PolymorphicValue(py::cast<int64_t>(obj));
} else if (py::isinstance<py::float_>(obj)) {
return PolymorphicValue(py::cast<double>(obj));
} else if (PyComplex_Check(obj.ptr())) {
return PolymorphicValue(py::cast<std::complex<double>>(obj));
}
NVF_THROW("Cannot convert provided py::handle to a PolymorphicValue.");
}

} // namespace

KernelArgumentHolder from_pyiterable(
const py::iterable& iter,
std::optional<int64_t> device) {
Expand All @@ -19,10 +39,10 @@ KernelArgumentHolder from_pyiterable(
// Allows for a Vector of Sizes to be inputed as a list/tuple
if (py::isinstance<py::list>(obj) || py::isinstance<py::tuple>(obj)) {
for (py::handle item : obj) {
args.push(torch::jit::toIValue(item, c10::AnyType::get()));
args.push(toPolymorphicValue(item));
}
} else {
args.push(torch::jit::toIValue(obj, c10::AnyType::get()));
args.push(toPolymorphicValue(obj));
}
}

Expand Down