fix: Initialize master_weight with params_dtype directly #1748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change fixes a potential precision loss in _initialize_affine_weight_cpu by initializing master_weight directly with params_dtype instead of creating it in torch.float and then casting.
Problem:
Previously, master_weight was created as torch.float32 and then cast to params_dtype.
If params_dtype is torch.float16 or torch.bfloat16, this casting could cause precision truncation.
While the effect might be small, in large-scale training such errors can accumulate, potentially affecting convergence.
Solution:
Initialize master_weight directly with params_dtype.
Avoids unnecessary casting and ensures precision is correct from the outset.
Benefits:
Improved numerical precision: Maintains intended precision during initialization, important for mixed-precision training.
Code clarity: The initialization now reflects the intended data type explicitly.
Impact:
Improves numerical stability in Megatron-LM without altering other behaviors.
No API changes or backward compatibility issues.