Skip to content

fix(ci): AUT-1080 retry live NCCL watchdog timeouts - #6054

Merged
ko3n1g merged 8 commits into
NVIDIA:mainfrom
svcnemo-autobot:fix/retry-nccl-timeout
Jul 28, 2026
Merged

ko3n1g merged 8 commits into
NVIDIA:mainfrom
svcnemo-autobot:fix/retry-nccl-timeout

Conversation

@svcnemo-autobot

@svcnemo-autobot svcnemo-autobot commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Background

GB200 job 89828563718 hung on a transient NCCL collective timeout. Validation also showed live cancellation must not intercept tests that intentionally inject retryable failures.

What changed

  • Detect NCCL watchdog timeouts in streamed logs and cancel the wedged attempt immediately.
  • Preserve post-exit retries for other flaky signatures.
  • Temporarily pin the companion NeMo Run cancellation fix.

Details

Live cancellation is limited to the hang-prone watchdog signature. Ordinary failures, including the persistent-rerun test’s injected NaN, finish normally before the existing retry classifier runs. Companion: NVIDIA-NeMo/Run#570.

Tested

  • Focused launcher tests — 4 passed
  • Black, isort, Ruff, and locked Pylint passed
  • Exact GB200 functional case delegated to PR CI

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from ko3n1g July 26, 2026 20:39
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 26, 2026 20:39
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g marked this pull request as ready for review July 26, 2026 20:42
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 5f1c5f3

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30223672378

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 27, 2026
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 7b135b8

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test bb7cd8a

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test cb9c796

@ko3n1g
ko3n1g added this pull request to the merge queue Jul 28, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30390824927

Merged via the queue into NVIDIA:main with commit 2658704 Jul 28, 2026
182 checks passed
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants