Skip to content

Conversation

@yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Oct 7, 2025

Description

The goal of this PR:

Analysis of Datadog logs for the ttysc MCP server revealed that the text2sql tool is the only component with a potential memory leak during observed incidents. To isolate this issue, a standalone version of the text2sql tool was developed. This standalone version minimizes external dependencies, retaining only vanna and milvus to preserve core logic.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added the DO NOT MERGE PR should not be merged; see PR for details label Oct 7, 2025
@yczhang-nv yczhang-nv changed the base branch from develop to release/1.3 October 7, 2025 04:35
@coderabbitai
Copy link

coderabbitai bot commented Oct 7, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
@yczhang-nv yczhang-nv changed the title [DO NOT MERGE] Investigating MCP server memory leak issue [DO NOT MERGE] Adding standalone MCP tool text2sql for load test and potential memory leak investigation Oct 9, 2025
@yczhang-nv yczhang-nv changed the title [DO NOT MERGE] Adding standalone MCP tool text2sql for load test and potential memory leak investigation [DO NOT MERGE] Add standalone MCP tool text2sql for load test and potential memory leak investigation Oct 9, 2025
Signed-off-by: Yuchen Zhang <[email protected]>
Signed-off-by: Yuchen Zhang <[email protected]>
@AnuradhaKaruppiah AnuradhaKaruppiah changed the base branch from release/1.3 to develop October 16, 2025 15:39
@AnuradhaKaruppiah AnuradhaKaruppiah changed the base branch from develop to release/1.3 October 16, 2025 15:41
@AnuradhaKaruppiah AnuradhaKaruppiah changed the base branch from release/1.3 to develop October 16, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE PR should not be merged; see PR for details

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant