-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jp itn #101
Conversation
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: BuyuanCui <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: BuyuanCui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
… into jp_itn_20231212 Signed-off-by: Alex Cui <[email protected]>
Signed-off-by: Alex Cui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Alex Cui <[email protected]>
for more information, see https://pre-commit.ci
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
@BuyuanCui should we close this PR in favor of #141 ? |
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
What does this PR do ?
Merge to main for Japanese support on cardinal, ordinal, time, date, fraction, decimal support
Add a one line overview of what this PR aims to accomplish.
This is a PR for Japanese ITN support.
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.