-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time, Money and Measure #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrafu
reviewed
Aug 29, 2024
mgrafu
reviewed
Aug 29, 2024
mgrafu
reviewed
Aug 29, 2024
nemo_text_processing/inverse_text_normalization/hi/data/time/second.tsv
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
Aug 29, 2024
nemo_text_processing/inverse_text_normalization/hi/data/whitelist/whitelist_time.tsv
Show resolved
Hide resolved
mgrafu
reviewed
Aug 29, 2024
nemo_text_processing/inverse_text_normalization/hi/data/whitelist/whitelist_fraction.tsv
Show resolved
Hide resolved
mgrafu
reviewed
Aug 29, 2024
mgrafu
reviewed
Aug 29, 2024
nemo_text_processing/inverse_text_normalization/hi/taggers/cardinal.py
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
Aug 29, 2024
nemo_text_processing/inverse_text_normalization/hi/taggers/decimal.py
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
Aug 29, 2024
mgrafu
reviewed
Aug 29, 2024
nemo_text_processing/inverse_text_normalization/hi/verbalizers/verbalize_final.py
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
Aug 29, 2024
mgrafu
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
tarushi2k2
changed the title
Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time
Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time, Money and Measure
Oct 21, 2024
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
…curacy Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: tarushi2k2 <[email protected]>
mgrafu
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.