Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time, Money and Measure #223

Merged
merged 30 commits into from
Oct 30, 2024

Conversation

tarushi2k2
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@tarushi2k2 tarushi2k2 changed the title Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time, Money and Measure Oct 21, 2024
tarushi2k2 and others added 16 commits October 21, 2024 16:23
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
@tarushi2k2 tarushi2k2 marked this pull request as ready for review October 21, 2024 10:59
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: Tarushi V <[email protected]>
@mgrafu mgrafu merged commit 9aa9118 into NVIDIA:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants