-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hindi TN Support for Cardinal, Decimal, Fraction, Date, Time, Money and Measure #241
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
nemo_text_processing/text_normalization/hi/data/whitelist/alternatives.tsv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Namrata Gachchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remaining files from the whitelist data class will be removed and single would be there
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
…g the file opened Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
…d word file Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
What does this PR do ?
This PR introduces Hindi support for a wide range of numerical and temporal formats, including:
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.