Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct signal for Windows #11898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct signal for Windows #11898

wants to merge 1 commit into from

Conversation

maxstrobel
Copy link

Windows uses signal.SIGTERM instead of signal.SIGKILL.

What does this PR do ?

Fixes wrong signal under Windows.

Collection: [Note which collection this PR will affect]

Changelog

  • Fixes wrong signal under Windows.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

@BBC-Esq @titu1994 @blisc @okuchaiev

Additional Information

@maxstrobel
fix: correct signal for Windows
fe8518f 
Windows uses `signal.SIGTERM` instead of `signal.SIGKILL`.

Signed-off-by: Strobel Maximilian (IFAG PSS SIS SCE ACM) <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.utils.exp_manager
nemo/utils/exp_manager.py:353:0: C0301: Line too long (120/119) (line-too-long)
nemo/utils/exp_manager.py:378:0: C0301: Line too long (124/119) (line-too-long)
nemo/utils/exp_manager.py:382:0: C0301: Line too long (122/119) (line-too-long)
nemo/utils/exp_manager.py:387:0: C0301: Line too long (127/119) (line-too-long)
nemo/utils/exp_manager.py:401:0: C0301: Line too long (120/119) (line-too-long)
nemo/utils/exp_manager.py:408:0: C0301: Line too long (120/119) (line-too-long)
nemo/utils/exp_manager.py:409:0: C0301: Line too long (126/119) (line-too-long)
nemo/utils/exp_manager.py:411:0: C0301: Line too long (136/119) (line-too-long)
nemo/utils/exp_manager.py:413:0: C0301: Line too long (139/119) (line-too-long)
nemo/utils/exp_manager.py:423:0: C0301: Line too long (123/119) (line-too-long)
nemo/utils/exp_manager.py:424:0: C0301: Line too long (128/119) (line-too-long)
nemo/utils/exp_manager.py:425:0: C0301: Line too long (132/119) (line-too-long)
nemo/utils/exp_manager.py:426:0: C0301: Line too long (127/119) (line-too-long)
nemo/utils/exp_manager.py:514:0: C0301: Line too long (122/119) (line-too-long)
nemo/utils/exp_manager.py:602:0: C0301: Line too long (208/119) (line-too-long)
nemo/utils/exp_manager.py:603:0: C0301: Line too long (230/119) (line-too-long)
nemo/utils/exp_manager.py:605:0: C0301: Line too long (178/119) (line-too-long)
nemo/utils/exp_manager.py:642:0: C0301: Line too long (136/119) (line-too-long)
nemo/utils/exp_manager.py:777:0: C0301: Line too long (121/119) (line-too-long)
nemo/utils/exp_manager.py:785:0: C0301: Line too long (156/119) (line-too-long)
nemo/utils/exp_manager.py:832:0: C0301: Line too long (141/119) (line-too-long)
nemo/utils/exp_manager.py:840:0: C0301: Line too long (152/119) (line-too-long)
nemo/utils/exp_manager.py:1110:0: C0301: Line too long (142/119) (line-too-long)
nemo/utils/exp_manager.py:1134:0: C0301: Line too long (154/119) (line-too-long)
nemo/utils/exp_manager.py:1200:0: C0301: Line too long (120/119) (line-too-long)
nemo/utils/exp_manager.py:1219:0: C0301: Line too long (123/119) (line-too-long)
nemo/utils/exp_manager.py:1245:0: C0301: Line too long (121/119) (line-too-long)
nemo/utils/exp_manager.py:91:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/exp_manager.py:106:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/exp_manager.py:132:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/exp_manager.py:141:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/exp_manager.py:150:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/exp_manager.py:161:0: C0115: Missing class docstring (missing-class-docstring)
nemo/utils/exp_manager.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:333:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:1126:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:1227:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:1246:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:1249:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/utils/exp_manager.py:1265:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.19/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@maxstrobel
Copy link
Author

Sorry for the duplicated PR - I closed the old one by accident (#11883)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxstrobel