Skip to content

fix(cli): resolve sandbox name for stop and status commands #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
latenighthackathon wants to merge 7 commits into from
Closed

fix(cli): resolve sandbox name for stop and status commands #1135

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
42d6325
fix(cli): resolve sandbox name for stop and status commands
latenighthackathon Mar 31, 2026
93f4bb5
fix(cli): use --sandbox arg instead of env var for service commands
latenighthackathon Mar 31, 2026
3d4fe31
refactor(cli): pass resolved sandbox to registrySandboxArg
latenighthackathon Apr 1, 2026
aa5553f
fix(cli): remove ensureApiKey from start() to match upstream behavior
latenighthackathon Apr 1, 2026
64c891a
Merge branch 'main' into fix/services-sandbox-name-resolution
cv Apr 1, 2026
8790d48
Merge branch 'main' into fix/services-sandbox-name-resolution
latenighthackathon Apr 1, 2026
6b84a32
Merge branch 'main' into fix/services-sandbox-name-resolution
latenighthackathon Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions bin/nemoclaw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,16 +766,19 @@ async function deploy(instanceName) {
);
}

async function start() {
function registrySandboxArg() {
const { defaultSandbox } = registry.listSandboxes();
const safeName =
defaultSandbox && /^[a-zA-Z0-9._-]+$/.test(defaultSandbox) ? defaultSandbox : null;
const sandboxEnv = safeName ? `SANDBOX_NAME=${shellQuote(safeName)}` : "";
run(`${sandboxEnv} bash "${SCRIPTS}/start-services.sh"`);
const safe = defaultSandbox && /^[a-zA-Z0-9._-]+$/.test(defaultSandbox) ? defaultSandbox : null;
return safe ? ` --sandbox ${shellQuote(safe)}` : "";
}

async function start() {
await ensureApiKey();
run(`bash "${SCRIPTS}/start-services.sh"${registrySandboxArg()}`);
}

function stop() {
run(`bash "${SCRIPTS}/start-services.sh" --stop`);
run(`bash "${SCRIPTS}/start-services.sh" --stop${registrySandboxArg()}`);
}

function debug(args) {
Expand Down Expand Up @@ -849,8 +852,8 @@ function showStatus() {
console.log("");
}

// Show service status
run(`bash "${SCRIPTS}/start-services.sh" --status`);
// Show service status — pass --sandbox so PID lookup uses the correct directory
run(`bash "${SCRIPTS}/start-services.sh" --status${registrySandboxArg()}`);
}

async function listSandboxes() {
Expand Down