Skip to content

fix(cli): map --follow to --tail for openshell logs streaming #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
senthilr-nv wants to merge 1 commit into from
Closed

fix(cli): map --follow to --tail for openshell logs streaming #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/nemoclaw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ async function sandboxStatus(sandboxName) {

function sandboxLogs(sandboxName, follow) {
const args = ["logs", sandboxName];
if (follow) args.push("--follow");
if (follow) args.push("--tail");
runOpenshell(args);
}

Expand Down
4 changes: 2 additions & 2 deletions test/cli.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe("CLI dispatch", () => {
expect(r.out.includes("nemoclaw debug")).toBeTruthy();
});

it("passes --follow through to openshell logs", () => {
it("maps --follow to openshell --tail flag", () => {
const home = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-cli-logs-follow-"));
const localBin = path.join(home, "bin");
const registryDir = path.join(home, ".nemoclaw");
Expand Down Expand Up @@ -144,7 +144,7 @@ describe("CLI dispatch", () => {
});

expect(r.code).toBe(0);
expect(fs.readFileSync(markerFile, "utf8")).toContain("logs alpha --follow");
expect(fs.readFileSync(markerFile, "utf8")).toContain("logs alpha --tail");
});

it("connect does not pre-start a duplicate port forward", () => {
Expand Down
Loading