Skip to content

refactor(cli): extract pure functions from onboard.js to typed TypeScript modules #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 7 commits into from
Apr 1, 2026
Merged

refactor(cli): extract pure functions from onboard.js to typed TypeScript modules #1240

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
448a863
refactor(cli): extract pure functions from onboard.js to typed TypeSc…
cv Apr 1, 2026
65fa902
test: add co-located tests for extracted TypeScript modules
cv Apr 1, 2026
eec919d
fix: make buildControlUiUrls token parameter optional
cv Apr 1, 2026
eb16b9e
Merge branch 'main' into cv/extract-onboard-pure-fns
cv Apr 1, 2026
01ced3b
fix(ci): build CLI TypeScript modules before type-checking
cv Apr 1, 2026
d3e2c33
Merge branch 'cv/extract-onboard-pure-fns' of github.com:NVIDIA/NemoC…
cv Apr 1, 2026
2ac85ce
refactor(cli): migrate preflight.js to TypeScript (#1262)
cv Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,10 @@ repos:
hooks:
- id: test-cli
name: Test (CLI)
entry: bash -c 'npx vitest run --project cli --coverage --coverage.reporter=text --coverage.reporter=json-summary --coverage.reportsDirectory=coverage/cli --coverage.include="bin/**/*.js" --coverage.exclude="test/**/*.js" --coverage.exclude="test/**/*.ts" && npx tsx scripts/check-coverage-ratchet.ts coverage/cli/coverage-summary.json ci/coverage-threshold-cli.json "CLI coverage"'
entry: bash -c 'npm run build:cli && npx vitest run --project cli --coverage --coverage.reporter=text --coverage.reporter=json-summary --coverage.reportsDirectory=coverage/cli --coverage.include="bin/**/*.js" --coverage.include="dist/lib/**/*.js" --coverage.exclude="test/**/*.js" --coverage.exclude="test/**/*.ts" && npx tsx scripts/check-coverage-ratchet.ts coverage/cli/coverage-summary.json ci/coverage-threshold-cli.json "CLI coverage"'
language: system
pass_filenames: false
files: ^(bin/|test/)
files: ^(bin/|src/|test/)
priority: 20

- id: test-plugin
Expand Down
Loading
Loading