Skip to content

fix(ci): write onboarding_step.json to skip Brev first-run wizard#1709

Merged
cv merged 2 commits intomainfrom
fix/brev-onboarding-step-json
Apr 9, 2026
Merged

fix(ci): write onboarding_step.json to skip Brev first-run wizard#1709
cv merged 2 commits intomainfrom
fix/brev-onboarding-step-json

Conversation

@cjagwani
Copy link
Copy Markdown
Contributor

@cjagwani cjagwani commented Apr 9, 2026

Summary

  • Add onboarding_step.json to the Brev CLI setup in the E2E workflow
  • Without it, brev ls triggers an interactive onboarding tutorial that hangs on the CI runner waiting for stdin

Root Cause

Follow-up to #1639. The credentials file fix restored auth, but brev ls still hangs because the Brev CLI's first-run onboarding wizard blocks on stdin. This file was also removed in 374a847 (#1470).

Evidence

  • Stuck run: 24213469934 — "Install Brev CLI" step hangs indefinitely
  • Local test with clean HOME + both files: brev ls returns immediately

Test plan

  • Merge to main, trigger e2e-brev with TEST_SUITE=full — confirm brev ls passes and tests actually run

Fixes #1638

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Improved CI/workflow configuration to prevent onboarding prompts from interfering with automated authentication checks.

Without this file, `brev ls` triggers the interactive onboarding
tutorial and hangs waiting for stdin on the CI runner. This file
was also removed in #1470 (374a847).

Tested locally: clean HOME with just credentials.json +
onboarding_step.json, `brev ls` returns immediately.

Fixes #1638

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8c21cd25-f720-4ed2-926f-a2189791d677

📥 Commits

Reviewing files that changed from the base of the PR and between 55ba539 and 503c697.

📒 Files selected for processing (1)
  • .github/workflows/e2e-brev.yaml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow step was added to write ~/.brev/onboarding_step.json with specific configuration values immediately after generating credentials. This prevents Brev's first-run wizard from blocking on stdin during CI authentication checks.

Changes

Cohort / File(s) Summary
Brev E2E Workflow Configuration
.github/workflows/e2e-brev.yaml
Added step to write onboarding state file (~/.brev/onboarding_step.json) to suppress first-run wizard prompt that was blocking CI authentication.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A wizard was blocking the CI lane,
So we wrote a file to ease the pain—
Onboarding state: step 1, shells run true,
No stdin waits, the tests break through! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately summarizes the main change: writing onboarding_step.json to skip Brev's first-run wizard in CI.
Linked Issues check ✅ Passed The PR addresses the core requirement from #1638 by writing onboarding_step.json to prevent the Brev first-run wizard from blocking CI, enabling brev ls to succeed.
Out of Scope Changes check ✅ Passed The change is focused solely on the E2E Brev workflow file with a minimal, targeted fix (2 lines added) directly addressing the blocking wizard issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/brev-onboarding-step-json

Comment @coderabbitai help to get the list of available commands and usage tips.

@cjagwani cjagwani self-assigned this Apr 9, 2026
@cv cv merged commit 485825d into main Apr 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): Brev E2E suite silently skips — brev login removed in #1470

2 participants