fix: offer Ollama install fallback when cloud API is unavailable#380
Open
futhgar wants to merge 3 commits intoNVIDIA:mainfrom
Open
fix: offer Ollama install fallback when cloud API is unavailable#380futhgar wants to merge 3 commits intoNVIDIA:mainfrom
futhgar wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds an Changes
Sequence DiagramsequenceDiagram
participant User
participant Onboard as Onboarding
participant Platform as PlatformDetector
participant Installer as PackageManager
participant Ollama
User->>Onboard: start onboarding
Onboard->>Onboard: check if ollama installed & running
alt not available
Onboard->>User: present "Install Ollama" option
User->>Onboard: choose install
Onboard->>Platform: detect platform
Platform-->>Onboard: darwin / linux
alt darwin
Onboard->>Installer: run "brew install ollama"
else linux
Onboard->>Installer: run "curl -fsSL https://ollama.com/install.sh | sh"
end
Installer->>Ollama: install
Onboard->>Ollama: start "OLLAMA_HOST=0.0.0.0:11434" + "ollama serve"
else available
Onboard->>Onboard: select existing "ollama" provider
end
Onboard->>User: continue to model selection
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bin/lib/onboard.js`:
- Around line 607-613: The installer calls that invoke run("brew install
ollama", { ignoreError: true }) and run("curl -fsSL
https://ollama.com/install.sh | sh", { ignoreError: true }) must not swallow
failures; update the onboarding logic so the run calls return and/or throw on
error (remove ignoreError: true) and explicitly check the result or catch
exceptions in the surrounding function (the installer branch in onboard.js) and
on failure log a clear error and abort onboarding (process.exit(1) or rethrow)
before proceeding to switch provider/model to Ollama.
- Around line 502-509: The current options builder omits the "install-ollama"
option when Ollama is present (hasOllama/ollamaRunning), causing
CI/non-interactive runs with NEMOCLAW_PROVIDER=install-ollama to fail; modify
the logic that populates options (the block referencing hasOllama, ollamaRunning
and pushing to options) to special-case the environment variable
NEMOCLAW_PROVIDER === "install-ollama" so the "install-ollama" entry is added
unconditionally when that env var is set, or alternatively relax the
non-interactive provider validation to accept "install-ollama" even if the
option wasn't pushed; update references in the same function that validate the
chosen provider to check process.env.NEMOCLAW_PROVIDER as an allowed provider.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 69e50485-aeb9-43e5-8f18-c3ea67223c15
📒 Files selected for processing (2)
bin/lib/onboard.jstest/onboard-selection.test.js
wscurran
added
enhancement: feature
When Ollama is not installed, the onboard wizard previously only offered the NVIDIA Cloud API option on Linux. If build.nvidia.com was overloaded or down, users couldn't obtain an API key and onboarding would fail with no fallback. Now, an "Install Ollama" option is always shown on both Linux and macOS when Ollama is not already present. On Linux, the official curl installer (ollama.com/install.sh) is used instead of Homebrew. This ensures users always have a local inference path available regardless of NVIDIA API server availability. Also adds install-ollama as a valid NEMOCLAW_PROVIDER value for non-interactive mode. Fixes NVIDIA#301 Signed-off-by: Josue Gomez <josue@guatulab.com>
…tall errors Address CodeRabbit review: - In non-interactive mode, fall back to the existing 'ollama' option when NEMOCLAW_PROVIDER=install-ollama but Ollama is already installed - Remove ignoreError from Ollama install commands so failures are caught immediately instead of silently continuing Signed-off-by: Josue Gomez <josue@guatulab.com> Signed-off-by: futhgar <jmaldonado.rosa@gmail.com>
futhgar
force-pushed
the
fix/skip-api-key-local-inference
branch
from
d94ddea to
d40b6fc
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bin/lib/onboard.js (1)
2216-2260: Minor indentation inconsistency at Line 2226.The
sleep(2)call has 8-space indentation instead of 6, breaking alignment with the surrounding code. This doesn't affect functionality but harms readability.🧹 Fix indentation
run("OLLAMA_HOST=0.0.0.0:11434 ollama serve > /dev/null 2>&1 &", { ignoreError: true }); - sleep(2); + sleep(2);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bin/lib/onboard.js` around lines 2216 - 2260, In the selected.key === "install-ollama" branch adjust the indentation of the sleep(2); line so it aligns with the surrounding console.log and run calls (same indentation level as the preceding run("OLLAMA_HOST=...") and console.log lines) — replace the 8-space indent with the 6-space indent used by the block to restore consistent formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/onboard-selection.test.js`:
- Around line 1327-1333: The test is selecting option "2" (OpenAI) instead of
Install Ollama; update the credentials.prompt stub in the test so the first
prompt returns "7" (Install Ollama) instead of "2" to exercise the ollama flow
(reference credentials.prompt and setupNim()), and add a fake curl binary into a
temporary bin and ensure the spawnSync call used by the code under test sees
that bin by updating the spawnSync/env used in the test to include the temp bin
at the front of PATH (reference spawnSync and PATH) so the install-ollama path
can detect curl and proceed.
---
Nitpick comments:
In `@bin/lib/onboard.js`:
- Around line 2216-2260: In the selected.key === "install-ollama" branch adjust
the indentation of the sleep(2); line so it aligns with the surrounding
console.log and run calls (same indentation level as the preceding
run("OLLAMA_HOST=...") and console.log lines) — replace the 8-space indent with
the 6-space indent used by the block to restore consistent formatting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 722fed8a-52cc-48e1-a9c7-c02618cb0873
📒 Files selected for processing (2)
bin/lib/onboard.jstest/onboard-selection.test.js
…test The test was selecting option 2 (OpenAI) instead of option 7 (install-ollama). The setupNim() options array puts install-ollama at position 7 when Ollama is not installed: build, openai, custom, anthropic, anthropicCompatible, gemini, install-ollama. Also fix __dirname → import.meta.dirname to match the ES module format used by all other tests in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.nvidia.comis overloaded or downcurl -fsSL https://ollama.com/install.sh | shinstaller on Linux (Homebrew on macOS)install-ollamaas a validNEMOCLAW_PROVIDERvalue for non-interactive/CI modeProblem
When Ollama is not installed and the NVIDIA API server is unavailable,
nemoclaw onboardpresents only the cloud option on Linux. Users can't get an API key and onboarding fails with no fallback path (issue #301).Fix
The
install-ollamaoption was already implemented for macOS but gated behindprocess.platform === "darwin". This PR extends it to Linux with the appropriate installer command. The change is minimal — no restructuring of the onboard flow.Fixes #301
Test plan
Install Ollama (Linux)option appears when Ollama is not installed on Linuxonboard-selection.test.jstests still passnpm testshows no new failures (pre-existing failures inruntime-shell.test.jsandinstall-preflight.test.jsare unrelated)Summary by CodeRabbit
New Features
Bug Fixes
Tests