docs: explain Linux Ollama bind requirement#972
docs: explain Linux Ollama bind requirement#972WuKongAI-CMU wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated onboarding documentation: README and inference-profiles now instruct that Local Ollama on Linux/Docker must bind to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/reference/inference-profiles.md (1)
79-85: Split sentences per line and keep present tense in behavior statements.Line 79 places multiple sentences on one line, and Line 85 uses future tense ("will fail") for current behavior.
Suggested edit
-On Linux hosts that run NemoClaw with Docker, the sandbox reaches Ollama through `http://host.openshell.internal:11434`, not the host shell's `localhost` socket. If Ollama is already running, make sure it listens on `0.0.0.0:11434` instead of `127.0.0.1:11434`, for example: +On Linux hosts that run NemoClaw with Docker, the sandbox reaches Ollama through `http://host.openshell.internal:11434`, not the host shell's `localhost` socket. +If Ollama is already running, make sure it listens on `0.0.0.0:11434` instead of `127.0.0.1:11434`. +For example. @@ -If Ollama only binds loopback, NemoClaw can detect it on the host but the sandbox-side validation step will fail because containers cannot reach it. +If Ollama only binds loopback, NemoClaw can detect it on the host but the sandbox-side validation step fails because containers cannot reach it.As per coding guidelines, "One sentence per line in source (makes diffs readable). Flag paragraphs where multiple sentences appear on the same line." and "Present tense. Flag future tense ('will') in descriptions of current behavior."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/reference/inference-profiles.md` around lines 79 - 85, Split the multi-sentence lines in the paragraph that begins "On Linux hosts that run NemoClaw with Docker, the sandbox reaches Ollama..." so each sentence is on its own source line (one sentence per line), and change any future-tense description of current behavior—specifically the phrase "will fail"—to present tense ("fails") in the sentence about sandbox-side validation; keep the rest of the wording intact and ensure the example command and note about binding remain each on their own lines.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/reference/inference-profiles.md`:
- Around line 81-83: Replace the fenced code block that currently uses ```bash
and contains the command "OLLAMA_HOST=0.0.0.0:11434 ollama serve" with a console
block: change the opening fence to ```console, prefix the command line with "$ "
so it reads "$ OLLAMA_HOST=0.0.0.0:11434 ollama serve", and keep the closing ```
fence; ensure all CLI examples follow this `console` + `$` prompt convention.
---
Nitpick comments:
In `@docs/reference/inference-profiles.md`:
- Around line 79-85: Split the multi-sentence lines in the paragraph that begins
"On Linux hosts that run NemoClaw with Docker, the sandbox reaches Ollama..." so
each sentence is on its own source line (one sentence per line), and change any
future-tense description of current behavior—specifically the phrase "will
fail"—to present tense ("fails") in the sentence about sandbox-side validation;
keep the rest of the wording intact and ensure the example command and note
about binding remain each on their own lines.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f96c2b22-8f39-44e4-b76e-54b686903b9c
📒 Files selected for processing (2)
README.mddocs/reference/inference-profiles.md
|
Addressed the formatting/doc-style nit on the Ollama guidance: split the multi-sentence paragraph into one sentence per line, switched the CLI example to |
Summary
host.openshell.internal0.0.0.0:11434bind for host Ollama servicesFixes #709.
Summary by CodeRabbit