fix(cli): remove unreachable plugin modules and associated tests#982
fix(cli): remove unreachable plugin modules and associated tests#982ksapru wants to merge 0 commit intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (8)
📝 WalkthroughWalkthroughThis PR removes 8 unreachable TypeScript modules and their test files that were compiled into the distribution but had no runtime import path from the plugin entry point. The deleted code includes blueprint runner orchestration, snapshot/restore migration logic, endpoint URL SSRF validation, and host migration state management. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2b244a6 to
5c269c1
Compare
|
After rebasing and running the full test suite locally, I found that the removed modules are still part of core execution and sandbox flows (causing timeouts and test failures). Reverting this change for now to avoid regressions. I’ll follow up with a more targeted cleanup of unused exports instead. |
Summary
Removes unreachable plugin modules that are compiled into
dist/but are not referenced from the plugin entry point, reducing package size and maintenance surface.Related Issue
Fixes #977
Changes
blueprint/runner.tsblueprint/snapshot.tsblueprint/ssrf.tscommands/migration-state.tsType of Change
Testing
npx prek run --all-filespasses (or equivalentlymake check).npm testpasses.make docsbuilds without warnings. (for doc-only changes)Checklist
General
Code Changes
npx prek run --all-filesauto-fixes formatting (ormake formatfor targeted runs).Doc Changes
Summary by CodeRabbit
Release Notes