Fix local mode handling of empty loader environment variables - #138
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
Fix local mode handling of empty loader environment variables#138sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
sylvesterkaczmarek
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
September 10, 2026 10:22
Collaborator
|
Thanks for the fix. This behavior is now covered on main by #133, including the empty process-loader resets and focused regression tests, so this PR has been superseded and can be closed. |
Author
|
Thanks. Closing as superseded by #133. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tier 3 local mode rejects process-loader environment variables before considering their values. The evaluator itself supplies empty loader variables such as
BASH_ENV, so a local run can fail before the agent process starts.This drops blocked loader variables when their value is empty while preserving the existing rejection for every non-empty value.
Closes #136.
Verification
make lintmake testmake buildFocused local-mode tests: 16 passed. Ruff and package build pass.
make testcompleted with 6034 passed, 17 skipped, and 5 failures unrelated to this change. The CLI golden failure and the three Anthropichttpx/httpx2failures reproduce on unmodified currentmain; the remaining DNS deadline test is timing-sensitive and passes when rerun alone.Release Impact
CHANGELOG.md