Skip to content

Fix local mode handling of empty loader environment variables - #138

Closed
sylvesterkaczmarek wants to merge 1 commit into
NVIDIA:mainfrom
sylvesterkaczmarek:bug-local-empty-loader-env
Closed

Fix local mode handling of empty loader environment variables#138
sylvesterkaczmarek wants to merge 1 commit into
NVIDIA:mainfrom
sylvesterkaczmarek:bug-local-empty-loader-env

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

Tier 3 local mode rejects process-loader environment variables before considering their values. The evaluator itself supplies empty loader variables such as BASH_ENV, so a local run can fail before the agent process starts.

This drops blocked loader variables when their value is empty while preserving the existing rejection for every non-empty value.

Closes #136.

Verification

  • I am familiar with the Contributing Guidelines
  • Added or updated focused tests
  • Updated documentation for user-visible changes
  • Ran make lint
  • Ran make test
  • Ran make build
  • Did not add credentials, private datasets, or proprietary benchmark content

Focused local-mode tests: 16 passed. Ruff and package build pass.

make test completed with 6034 passed, 17 skipped, and 5 failures unrelated to this change. The CLI golden failure and the three Anthropic httpx/httpx2 failures reproduce on unmodified current main; the remaining DNS deadline test is timing-sensitive and passes when rerun alone.

Release Impact

  • No user-visible release note needed
  • Updated CHANGELOG.md

Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
@rng1995

rng1995 commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the fix. This behavior is now covered on main by #133, including the empty process-loader resets and focused regression tests, so this PR has been superseded and can be closed.

@sylvesterkaczmarek

Copy link
Copy Markdown
Author

Thanks. Closing as superseded by #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tier 3 --env-mode local always fails: the evaluator's own managed runtime env injects BASH_ENV, which local mode's command filter rejects

2 participants