Conversation
deepujain
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
September 15, 2026 00:17
Signed-off-by: Deepak Jain <deepujain@gmail.com>
deepujain
force-pushed
the
fix/139-non-progressing-embedding-windows
branch
from
September 15, 2026 00:18
b4d3486 to
e18c1f6
Compare
rng1995
reviewed
Sep 16, 2026
Signed-off-by: Deepak Jain <deepujain@gmail.com>
Collaborator
|
@deepujain Please resolve merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #139.
Verification
.venv/bin/python -m pytest -q tests/embedding/test_client.py— 31 passedmake PYTHON=.venv/bin/python lint— passed.venv/bin/python -m build— sdist and wheel built successfullygit diff --check origin/main...HEAD— passedmake PYTHON=.venv/bin/python test— 6,054 passed, 18 skipped, 4 deselected, 4 unrelated baseline failures: one CLI golden-surface drift and three Anthropic SDKhttpx2compatibility expectationsRelease Impact
Embedding chunk configuration now fails with an actionable
SimilarityConfigErrorinstead of allowing a zero or negative step to stall the fixed-size splitter. The change is backward compatible for valid chunk settings.