Conversation
Signed-off-by: Deepak Jain <deepujain@gmail.com>
deepujain
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
September 15, 2026 00:30
rng1995
reviewed
Sep 16, 2026
| and not ledger_exceptions | ||
| and not limitations | ||
| and report_metadata.get("has_executable_scripts") is False | ||
| and "not_applicable" in analyzer_states |
Collaborator
There was a problem hiding this comment.
[P1] Verify which analyzers are not applicable. Reducing all evidence to a set of states lets any required zero-work analyzer activate this exception. Starting from the new docs-only payload, change mcp_tool_poisoning to status="not_applicable" with planned_work=completed=0; validation still passes, although SkillSpector 2.11.2 normally runs that analyzer over SKILL.md with planned/completed work of 1. This can turn missing MCP security analysis plus an explicit partial verdict into a clean scan. Match the exact allowed docs-only N/A analyzer IDs (and reason codes/version), and require every other required analyzer to be completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partialcompleteness only when the scan has 100% coverage and every analyzer is either completed or not applicableCloses #137.
Verification
.venv/bin/python -m pytest -q tests/validators/test_security.py— 342 passedmake PYTHON=.venv/bin/python lint— passed.venv/bin/python -m build— sdist and wheel built successfullygit diff --check origin/main...HEAD— passedmake PYTHON=.venv/bin/python test— 6,061 passed, 18 skipped, 4 deselected, 4 unrelated baseline failures: one CLI golden-surface drift and three Anthropic SDKhttpx2compatibility expectationsRelease Impact
Documentation-only skills can pass security validation when SkillSpector inspected the complete component inventory and reports code-dependent analyzers as not applicable. Reports with any incomplete evidence continue to fail closed.