migrate internal changes #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mlir-tensorrt] NFC: fix build when NCCL is ON but MPI is OFF
GitOrigin-RevId: 8c365f7839bc39903c21a6fffe370bcff0f3f074
[mlir-tensorrt][cmake] Refactor compilation options into dedicated CMake module, add extra checks mode
This change consolidates handling of global compilation options (that are
specific to MTRT and not handled as part of
HandleLLVMOptions) intoa dedicated CMake module. It adds additional CMake cache options for
enabling '-Werror' globally and for addition additional warnings and
runtime checks recommended by
https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html.
By default,
MLIR_TRT_ENABLE_EXTRA_CHECKSandMLIR_TRT_ENABLE_WERRORareset to
OFF, but the idea is to enable them in CI in the future.In addition, fix some lingering warnings and build issues discovered
when testing with the extra checks mode and Werror enabled:
GitOrigin-RevId: 39f5e91697a20a65da2a5374b90366aba005f889
[mlir-tensorrt] Fix const fold execution aliasing and multi-device runtime issues
Fixes two issues that manifested as non-fatal error logs related to
CUDA runtime function call failures during compilation or execution
of a test program. Such errors were logged when e.g. we have no
path to propgate the error outwards (such as calling
cudaFreein adestructor).
Despite the similar symptoms, there were too different root causes:
In the
execute-constant-foldable-subgraphspass, we previouslyhad an issue where a function returning multiple results could return
two values which alias each othera, which is a violation of the
compiler-runtime ABI contract. We fixed this for ABI v1 in
ee26682 but forgot to update the
actual pipeline in the "execute-constant-foldable-subgraphs" pass.
This is now fixed. In addition, we now give each outlined sub-module
a unique name so that the IR printing doesn't clobber debug artifacts
for different constant foldable modules.
The second issues is that in multi-device setups, we need to ensure
that CUDA events created as part of the pinned memory pool allocator
are associated with the correct device. Simplify the existing infra
by moving the pinned memory allocator to be part of the runtime client
only, not the runtime session. The allocator now has a CUDA event
pool for each device.
GitOrigin-RevId: 2c5b5e7026d04150ebae2f40e25faf42d2af70df
[mlir-tensorrt] NFC: bump version to 0.4.3
GitOrigin-RevId: 9eb762aaf5edcc4e24220a67cc96c25b94c36173