Skip to content

Conversation

@jberchtold-nvidia
Copy link
Collaborator

Description

This PR fixes the early returns in quantize_transpose_vector_blockwise_fp4 with an NVTE_CHECK so error messages are reported. Additionally, if doing a colwise-only quantization the colwise data is properly checked.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Replace early returns with NVTE_CHECK in quantize_transpose_vector_blockwise_fp4
  • In quantize_transpose_vector_blockwise_fp4 when doing colwise-only quantization, the colwise dtype is now checked as fp4 instead of rowwise.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@jberchtold-nvidia
Copy link
Collaborator Author

/te-ci L1

Copy link
Collaborator

@Oleg-Goncharov Oleg-Goncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jberchtold-nvidia jberchtold-nvidia merged commit 060811c into NVIDIA:main Oct 24, 2025
49 of 54 checks passed
@jberchtold-nvidia jberchtold-nvidia deleted the jberchtold/fix-quantize-transpose-nvte-checks branch October 24, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants