Skip to content

Fix hybrid extra state size mismatch - #3499

Merged
negvet merged 2 commits into
NVIDIA:mainfrom
negvet:fix_extra_state_size_mismatch_hybrid
Sep 28, 2026
Merged

negvet merged 2 commits into
NVIDIA:mainfrom
negvet:fix_extra_state_size_mismatch_hybrid

Conversation

@negvet

@negvet negvet commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Evgeny <etsykunov@nvidia.com>
@negvet

negvet commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch

@negvet
negvet marked this pull request as ready for review September 14, 2026 07:47
@greptile-apps

greptile-apps Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Test file adjusts checkpoint serialization logic.

The PR appears safe to merge based on the changes since the previous review.

Summary

The PR updates the FSDP2 hybrid checkpoint parity test to exclude variable-sized _extra_state entries from the saved and loaded model state, then loads the remaining state non-strictly. The changes since the previous review are a merge from main; they do not change this PR’s test patch.

Reviews (2) · Last reviewed commit: "Merge branch 'main' into fix_extra_state..."

@pggPL
pggPL self-requested a review September 28, 2026 11:42

@pggPL pggPL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@negvet
negvet merged commit b86c660 into NVIDIA:main Sep 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants