Repository navigation
Skip fetching unused next tile in Mxfp8 quantization kernel - #3500
Merged
Merged
Conversation
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Contributor
Greptile SummaryThis PR optimizes the MXFP8 cast-only and swizzle kernel by avoiding a speculative fetch after the final iteration-space tile.
Confidence Score: 5/5The PR appears safe to merge because the added guard skips only an unused out-of-range prefetch while preserving every fetch required by the consumer pipeline. The changed kernel has one reachable configuration with four iteration tiles and two pipeline stages. Tiles 0–3 are fetched before consumption, while the new condition becomes false only for next tile index 4 after tile 3 has already been staged. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
P["Prologue: fetch tile 0"] --> I0["Iteration 0: fetch tile 1; consume tile 0"]
I0 --> I1["Iteration 1: fetch tile 2; consume tile 1"]
I1 --> I2["Iteration 2: fetch tile 3; consume tile 2"]
I2 --> I3["Iteration 3: skip next=4 fetch; consume tile 3"]
I3 --> O["Commit output"]
Reviews (1): Last reviewed commit: "mxfp8 quant: skip fetching next tile" | Re-trigger Greptile |
Collaborator
|
/te-ci |
Oleg-Goncharov
approved these changes
Sep 9, 2026
Oleg-Goncharov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. We can merge it once the CI tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip fetching the next unused tile in the for-loop logic. This optimization give 5% additional perf improvement for mxfp8 cast-only + swizzle kernel.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: