Disable fast-math for ICC (#1252)

We test exact floating point behavior, this can lead to flakyness in the libcu++ test suite
NVIDIA · Jan 9, 2024 · 2771c61 · 2771c61
1 parent 8c0bd44
commit 2771c61
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libcudacxx/libcxx/CMakeLists.txt b/libcudacxx/libcxx/CMakeLists.txt
@@ -612,7 +612,7 @@ function(cxx_add_warning_flags target)
       -Wno-literal-suffix
       -Wno-c++14-compat
       -Wno-noexcept-type)
-  elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "IntelLLVM")
+  elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "IntelLLVM" OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Intel")
     target_add_compile_flags_if_supported(${target} PRIVATE
       -fno-fast-math)
   endif()

diff --git a/libcudacxx/test/libcudacxx/CMakeLists.txt b/libcudacxx/test/libcudacxx/CMakeLists.txt
@@ -50,7 +50,7 @@ if (MSVC)
 endif()
 
 # Intel OneAPI compiler has fast math enabled by default which breaks almost all floating point tests
-if (${CMAKE_CXX_COMPILER_ID} STREQUAL "IntelLLVM")
+if (${CMAKE_CXX_COMPILER_ID} STREQUAL "IntelLLVM" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Intel")
   set(LIBCUDACXX_TEST_COMPILER_FLAGS
     "${LIBCUDACXX_TEST_COMPILER_FLAGS} \
     --compiler-options=-fno-fast-math")