GH Infra: project automation and issue template fixes (#297)

* Change from App auth to an org secret * Fix labels in issue templates * Revert app secret method, not the root cause * Move draft conversion, exit if pull_request_review
NVIDIA · Aug 16, 2023 · 380d381 · 380d381
1 parent e459eeb
commit 380d381
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -1,7 +1,7 @@
 name: Bug Report
 description: Create a report to help us improve
 title: '[BUG]: '
-labels: ['Bug']
+labels: ['bug']
 body:
   - type: checkboxes
     id: check-duplicates

diff --git a/.github/ISSUE_TEMPLATE/doc_request.yml b/.github/ISSUE_TEMPLATE/doc_request.yml
@@ -1,7 +1,7 @@
 name: Documentation Request
 description: Suggest an idea to improve CCCL
 title: '[DOC]: '
-labels: ['Doc']
+labels: ['doc']
 
 body:
   - type: checkboxes

diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml
@@ -1,7 +1,7 @@
 name: Feature Request
 description: Suggest an idea to improve CCCL
 title: '[FEA]: '
-labels: ['Feature']
+labels: ['feature request']
 body:
   - type: checkboxes
     id: check-duplicates

diff --git a/.github/workflows/project_automation_set_in_progress.yml b/.github/workflows/project_automation_set_in_progress.yml
@@ -42,6 +42,10 @@ env:
 jobs:
   query_and_mutate_project_fields:
     runs-on: ubuntu-latest
+
+    permissions:
+      issues: write
+      pull-requests: write
 
     steps:
       - name: Check if changes requested from a reviewer
@@ -51,8 +55,20 @@ jobs:
             if [ ${{ github.event.review.state }} != 'changes_requested' ]; then
               echo "Changes not requested, exiting"
               exit 0
+            
+            # If it is requesting changes, set PR to draft
+            # We use the default token here since we're granting write access to the PR
+            elif [ ${{ github.event.pull_request.draft }} == true ]; then
+              gh api graphql -f query='
+                mutation {
+                  convertPullRequestToDraft(input: {pullRequestId: "${{ env.PR_GLOBAL_ID }}"}) {
+                    clientMutationId
+                  }
+                }'
+              exit 0
             fi
           fi
+        continue-on-error: true
 
       - name: Generate token
         id: generate_token
@@ -334,19 +350,3 @@ jobs:
                 fi
             done
         continue-on-error: true
-
-      - name: set PR to draft
-        id: set_pr_draft
-        # only run if PR is not a draft
-        if: ${{ github.event.pull_request.draft }} == false
-        env:
-            GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }}
-        run: |
-            # Set the PR to draft using the graphQL API
-            gh api graphql -f query='
-              mutation {
-                convertPullRequestToDraft(input: {pullRequestId: "${{ env.PR_GLOBAL_ID }}"}) {
-                  clientMutationId
-                }
-              }'
-        continue-on-error: true