Skip to content

Commit

Permalink
Reviewer feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
bernhardmgruber committed Jul 4, 2024
1 parent f2ff040 commit f0ee1c9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion libcudacxx/include/cuda/std/detail/libcxx/include/cmath
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ _LIBCUDACXX_INLINE_VISIBILITY constexpr _Fp __lerp(_Fp __a, _Fp __b, _Fp __t) no
return __b;
}
const _Fp __x = __a + __t * (__b - __a);
if ((__t > 1) == (__b > __a))
if (__t > 1 == __b > __a)
{
return __b < __x ? __x : __b;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ struct _CCCL_VISIBILITY_HIDDEN triple_chevron
}

template <class Arg>
void _CCCL_DEVICE copy_arg(char*& buffer, size_t& offset, Arg arg) const
void _CCCL_DEVICE copy_arg(char* buffer, size_t& offset, Arg arg) const
{
// TODO(bgruber): we should make sure that we can actually byte-wise copy Arg, but this fails with some tests
// static_assert(::cuda::std::is_trivially_copyable<Arg>::value, "");
Expand Down

0 comments on commit f0ee1c9

Please sign in to comment.