-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Automation: Move PR and Linked Issues to In Progress #170
Conversation
After some talks + seeing some potential, I'm reworking this to be a little more "full automation". |
Testing graphQL mutation for setting to draft. Success! |
Workflow UpdateThere are now 3 actions:
Set In ProgressThis action runs when a PR is opened, converted to a draft, or a review requests changes. It:
Set In ReviewThis action runs when a PR is marked
Synchronize IssuesThis action runs when the PR is edited, we're interested here because we should be editing in closing keywords for issues if new or old issues are realized to be closed by this PR. It:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we just want to add a project_automation/
directory instead of prefixing the workflow file names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I didn't know that was an option, I thought all workflows had to be in the .workflows/
folder. Happy to move them and remove the prefix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I obviously didn't go through all the graphql stuff in detail, but I followed the high level workflow and it looks awesome!
Do we want to update any of the process docs in the Wiki as part of this PR? I really like the idea of having a state diagram in there so it's easy to see at a glance how a PR/issue evolves over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test "review"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App Test 2 The functional skip logic made it not generate a token. But it shows as a failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test requesting changes
Merging this with the failed check. This failure is expected because the action needs access to repo secrets that aren't available on forks. It has been tested elsewhere and confirmed that it will work once merged. |
Description
closes #169
This PR creates a new GitHub action,
project_automation_set_in_progress.yml
. It uses the ProjectsV2 graphQL API to perform the automations. This was designed to not require any external tools, nor install anything into the Actions runner to minimize runtime.StepsSEE COMMENT BELOW THE WORKFLOW HAS BEEN SIGNIFICANTLY UPDATED1
secondedited
trigger (which we need if we want to add additional issue links after opening the PR) it's possible the action could trigger when the PR is in theReview
status, orDone
Todo
ornull
, update the PR toIn Progress
Todo
ornull
, update the linked issues toIn Progress
All steps have
continue-on-error: True
so that this action cannot count as a failure when considering it as a CI check. It will make failures silent and we'll need to manually watch for failure, but I think it's an acceptable tradeoff.(It also adds a missing copyright header to the triage rotation workflow.)
Checklist