Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing qualification of pow in two instances #1784

Merged
merged 1 commit into from
May 28, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented May 28, 2024

This might lead to ambiguous overload resolution and breaks some builds.

Fixes nvbug4480737

This might lead to ambiguous overload resolution and breaks some builds.

Fixes nvbug4480737
@miscco miscco marked this pull request as ready for review May 28, 2024 08:34
@miscco miscco requested review from a team as code owners May 28, 2024 08:34
@miscco miscco added thrust For all items related to Thrust. bug: functional nvbug Has an associated internal NVIDIA NVBug. labels May 28, 2024
@miscco miscco enabled auto-merge (squash) May 28, 2024 08:43
Copy link
Contributor

🟩 CI Results: Pass: 100%/198 | Total Time: 2d 13h | Avg Time: 18m 47s | Hits: 86%/132439
  • 🟩 thrust: Pass: 100%/99 | Total Time: 12h 42m | Avg Time: 7m 42s | Hits: 99%/50817

    🟩 cpu
      🟩 amd64              Pass: 100%/91  | Total Time: 11h 27m | Avg Time:  7m 33s | Hits:  99%/46709 
      🟩 arm64              Pass: 100%/8   | Total Time:  1h 15m | Avg Time:  9m 26s | Hits:  99%/4108  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total Time:  1h 21m | Avg Time:  5m 24s | Hits:  99%/7700  
      🟩 11.8               Pass: 100%/3   | Total Time: 16m 25s | Avg Time:  5m 28s | Hits:  99%/1542  
      🟩 12.4               Pass: 100%/81  | Total Time: 11h 05m | Avg Time:  8m 12s | Hits:  99%/41575 
    🟩 cudacxx_full
      🟩 clang-cuda16       Pass: 100%/2   | Total Time:  9m 46s | Avg Time:  4m 53s | Hits:  99%/1026  
      🟩 nvcc11.1           Pass: 100%/15  | Total Time:  1h 21m | Avg Time:  5m 24s | Hits:  99%/7700  
      🟩 nvcc11.8           Pass: 100%/3   | Total Time: 16m 25s | Avg Time:  5m 28s | Hits:  99%/1542  
      🟩 nvcc12.4           Pass: 100%/79  | Total Time: 10h 55m | Avg Time:  8m 17s | Hits:  99%/40549 
    🟩 cudacxx_name
      🟩 clang-cuda         Pass: 100%/2   | Total Time:  9m 46s | Avg Time:  4m 53s | Hits:  99%/1026  
      🟩 nvcc               Pass: 100%/97  | Total Time: 12h 32m | Avg Time:  7m 45s | Hits:  99%/49791 
    🟩 cxx_full
      🟩 clang9             Pass: 100%/6   | Total Time: 36m 43s | Avg Time:  6m 07s | Hits:  99%/3078  
      🟩 clang10            Pass: 100%/3   | Total Time: 14m 50s | Avg Time:  4m 56s | Hits:  99%/1539  
      🟩 clang11            Pass: 100%/4   | Total Time: 32m 46s | Avg Time:  8m 11s | Hits:  99%/2052  
      🟩 clang12            Pass: 100%/4   | Total Time: 22m 37s | Avg Time:  5m 39s | Hits:  99%/2052  
      🟩 clang13            Pass: 100%/4   | Total Time: 38m 00s | Avg Time:  9m 30s | Hits:  99%/2052  
      🟩 clang14            Pass: 100%/4   | Total Time: 20m 31s | Avg Time:  5m 07s | Hits:  99%/2052  
      🟩 clang15            Pass: 100%/4   | Total Time: 32m 27s | Avg Time:  8m 06s | Hits:  99%/2052  
      🟩 clang16            Pass: 100%/14  | Total Time:  2h 00m | Avg Time:  8m 36s | Hits:  99%/7182  
      🟩 gcc6               Pass: 100%/2   | Total Time:  7m 33s | Avg Time:  3m 46s | Hits:  99%/1026  
      🟩 gcc7               Pass: 100%/6   | Total Time: 29m 07s | Avg Time:  4m 51s | Hits:  99%/3084  
      🟩 gcc8               Pass: 100%/6   | Total Time: 35m 57s | Avg Time:  5m 59s | Hits:  99%/3084  
      🟩 gcc9               Pass: 100%/6   | Total Time: 28m 32s | Avg Time:  4m 45s | Hits:  99%/3084  
      🟩 gcc10              Pass: 100%/4   | Total Time: 23m 51s | Avg Time:  5m 57s | Hits:  99%/2056  
      🟩 gcc11              Pass: 100%/7   | Total Time: 46m 38s | Avg Time:  6m 39s | Hits:  99%/3598  
      🟩 gcc12              Pass: 100%/16  | Total Time:  2h 54m | Avg Time: 10m 54s | Hits:  99%/8224  
      🟩 Intel2023.2.0      Pass: 100%/3   | Total Time: 18m 55s | Avg Time:  6m 18s | Hits:  99%/1548  
      🟩 MSVC14.16          Pass: 100%/1   | Total Time: 14m 46s | Avg Time: 14m 46s | Hits:  97%/509   
      🟩 MSVC14.29          Pass: 100%/2   | Total Time: 25m 06s | Avg Time: 12m 33s | Hits:  97%/1018  
      🟩 MSVC14.39          Pass: 100%/3   | Total Time: 39m 06s | Avg Time: 13m 02s | Hits:  97%/1527  
    🟩 cxx_name
      🟩 clang              Pass: 100%/43  | Total Time:  5h 18m | Avg Time:  7m 24s | Hits:  99%/22059 
      🟩 gcc                Pass: 100%/47  | Total Time:  5h 46m | Avg Time:  7m 21s | Hits:  99%/24156 
      🟩 Intel              Pass: 100%/3   | Total Time: 18m 55s | Avg Time:  6m 18s | Hits:  99%/1548  
      🟩 MSVC               Pass: 100%/6   | Total Time:  1h 18m | Avg Time: 13m 09s | Hits:  97%/3054  
    🟩 gpu
      🟩 v100               Pass: 100%/99  | Total Time: 12h 42m | Avg Time:  7m 42s | Hits:  99%/50817 
    🟩 jobs
      🟩 build              Pass: 100%/91  | Total Time: 10h 06m | Avg Time:  6m 39s | Hits:  99%/46709 
      🟩 test               Pass: 100%/8   | Total Time:  2h 35m | Avg Time: 19m 29s | Hits:  99%/4108  
    🟩 os
      🟩 ubuntu18.04        Pass: 100%/14  | Total Time:  1h 06m | Avg Time:  4m 44s | Hits:  99%/7191  
      🟩 ubuntu20.04        Pass: 100%/35  | Total Time:  3h 44m | Avg Time:  6m 24s | Hits:  99%/17968 
      🟩 ubuntu22.04        Pass: 100%/44  | Total Time:  6h 33m | Avg Time:  8m 56s | Hits:  99%/22604 
      🟩 windows2022        Pass: 100%/6   | Total Time:  1h 18m | Avg Time: 13m 09s | Hits:  97%/3054  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total Time: 16m 25s | Avg Time:  5m 28s | Hits:  99%/1542  
      🟩 90a                Pass: 100%/4   | Total Time: 13m 21s | Avg Time:  3m 20s | Hits:  99%/2056  
    🟩 std
      🟩 11                 Pass: 100%/26  | Total Time:  2h 50m | Avg Time:  6m 33s | Hits:  99%/13354 
      🟩 14                 Pass: 100%/29  | Total Time:  3h 46m | Avg Time:  7m 48s | Hits:  99%/14881 
      🟩 17                 Pass: 100%/28  | Total Time:  3h 36m | Avg Time:  7m 44s | Hits:  99%/14372 
      🟩 20                 Pass: 100%/16  | Total Time:  2h 28m | Avg Time:  9m 17s | Hits:  99%/8210  
    
  • 🟩 cub: Pass: 100%/99 | Total Time: 2d 01h | Avg Time: 29m 52s | Hits: 79%/81622

    🟩 cpu
      🟩 amd64              Pass: 100%/91  | Total Time:  1d 21h | Avg Time: 30m 02s | Hits:  79%/74830 
      🟩 arm64              Pass: 100%/8   | Total Time:  3h 42m | Avg Time: 27m 52s | Hits:  77%/6792  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total Time:  5h 27m | Avg Time: 21m 48s | Hits:  75%/11525 
      🟩 11.8               Pass: 100%/3   | Total Time:  1h 35m | Avg Time: 31m 42s | Hits:  77%/2547  
      🟩 12.4               Pass: 100%/81  | Total Time:  1d 18h | Avg Time: 31m 17s | Hits:  79%/67550 
    🟩 cudacxx_full
      🟩 clang-cuda16       Pass: 100%/2   | Total Time: 30m 40s | Avg Time: 15m 20s | Hits:  82%/1406  
      🟩 nvcc11.1           Pass: 100%/15  | Total Time:  5h 27m | Avg Time: 21m 48s | Hits:  75%/11525 
      🟩 nvcc11.8           Pass: 100%/3   | Total Time:  1h 35m | Avg Time: 31m 42s | Hits:  77%/2547  
      🟩 nvcc12.4           Pass: 100%/79  | Total Time:  1d 17h | Avg Time: 31m 42s | Hits:  79%/66144 
    🟩 cudacxx_name
      🟩 clang-cuda         Pass: 100%/2   | Total Time: 30m 40s | Avg Time: 15m 20s | Hits:  82%/1406  
      🟩 nvcc               Pass: 100%/97  | Total Time:  2d 00h | Avg Time: 30m 10s | Hits:  79%/80216 
    🟩 cxx_full
      🟩 clang9             Pass: 100%/6   | Total Time:  2h 12m | Avg Time: 22m 02s | Hits:  76%/4872  
      🟩 clang10            Pass: 100%/3   | Total Time:  1h 09m | Avg Time: 23m 02s | Hits:  78%/2553  
      🟩 clang11            Pass: 100%/4   | Total Time:  1h 32m | Avg Time: 23m 01s | Hits:  78%/3404  
      🟩 clang12            Pass: 100%/4   | Total Time:  1h 44m | Avg Time: 26m 11s | Hits:  78%/3404  
      🟩 clang13            Pass: 100%/4   | Total Time:  1h 53m | Avg Time: 28m 20s | Hits:  78%/3404  
      🟩 clang14            Pass: 100%/4   | Total Time:  1h 31m | Avg Time: 22m 57s | Hits:  77%/3404  
      🟩 clang15            Pass: 100%/4   | Total Time:  5h 18m | Avg Time:  1h 19m | Hits:  77%/3396  
      🟩 clang16            Pass: 100%/14  | Total Time:  8h 06m | Avg Time: 34m 42s | Hits:  85%/11594 
      🟩 gcc6               Pass: 100%/2   | Total Time: 39m 33s | Avg Time: 19m 46s | Hits:  75%/1546  
      🟩 gcc7               Pass: 100%/6   | Total Time:  2h 10m | Avg Time: 21m 49s | Hits:  76%/4875  
      🟩 gcc8               Pass: 100%/6   | Total Time:  2h 13m | Avg Time: 22m 12s | Hits:  76%/4875  
      🟩 gcc9               Pass: 100%/6   | Total Time:  2h 11m | Avg Time: 21m 53s | Hits:  76%/4875  
      🟩 gcc10              Pass: 100%/4   | Total Time:  1h 49m | Avg Time: 27m 16s | Hits:  77%/3404  
      🟩 gcc11              Pass: 100%/7   | Total Time:  3h 13m | Avg Time: 27m 36s | Hits:  77%/5943  
      🟩 gcc12              Pass: 100%/16  | Total Time:  8h 30m | Avg Time: 31m 55s | Hits:  80%/13584 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total Time:  1h 26m | Avg Time: 28m 59s | Hits:  75%/2325  
      🟩 MSVC14.16          Pass: 100%/1   | Total Time: 44m 35s | Avg Time: 44m 35s | Hits:  81%/694   
      🟩 MSVC14.29          Pass: 100%/2   | Total Time:  1h 04m | Avg Time: 32m 24s | Hits:  81%/1388  
      🟩 MSVC14.39          Pass: 100%/3   | Total Time:  1h 44m | Avg Time: 34m 56s | Hits:  81%/2082  
    🟩 cxx_name
      🟩 clang              Pass: 100%/43  | Total Time: 23h 27m | Avg Time: 32m 44s | Hits:  80%/36031 
      🟩 gcc                Pass: 100%/47  | Total Time: 20h 48m | Avg Time: 26m 33s | Hits:  78%/39102 
      🟩 Intel              Pass: 100%/3   | Total Time:  1h 26m | Avg Time: 28m 59s | Hits:  75%/2325  
      🟩 MSVC               Pass: 100%/6   | Total Time:  3h 34m | Avg Time: 35m 42s | Hits:  81%/4164  
    🟩 gpu
      🟩 v100               Pass: 100%/99  | Total Time:  2d 01h | Avg Time: 29m 52s | Hits:  79%/81622 
    🟩 jobs
      🟩 build              Pass: 100%/91  | Total Time:  1d 16h | Avg Time: 26m 59s | Hits:  77%/74830 
      🟩 test               Pass: 100%/8   | Total Time:  8h 20m | Avg Time:  1h 02m | Hits:  95%/6792  
    🟩 os
      🟩 ubuntu18.04        Pass: 100%/14  | Total Time:  4h 42m | Avg Time: 20m 10s | Hits:  75%/10831 
      🟩 ubuntu20.04        Pass: 100%/35  | Total Time: 14h 25m | Avg Time: 24m 42s | Hits:  77%/29785 
      🟩 ubuntu22.04        Pass: 100%/44  | Total Time:  1d 02h | Avg Time: 36m 15s | Hits:  80%/36842 
      🟩 windows2022        Pass: 100%/6   | Total Time:  3h 34m | Avg Time: 35m 42s | Hits:  81%/4164  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total Time:  1h 35m | Avg Time: 31m 42s | Hits:  77%/2547  
      🟩 90a                Pass: 100%/4   | Total Time: 50m 44s | Avg Time: 12m 41s | Hits:  77%/3396  
    🟩 std
      🟩 11                 Pass: 100%/26  | Total Time: 11h 22m | Avg Time: 26m 16s | Hits:  79%/21643 
      🟩 14                 Pass: 100%/29  | Total Time: 13h 28m | Avg Time: 27m 52s | Hits:  79%/23725 
      🟩 17                 Pass: 100%/28  | Total Time: 12h 35m | Avg Time: 26m 59s | Hits:  78%/22961 
      🟩 20                 Pass: 100%/16  | Total Time: 11h 49m | Avg Time: 44m 22s | Hits:  81%/13293 
    

🏃‍ Runner counts (total jobs: 198)

# Runner
154 linux-amd64-cpu16
16 linux-arm64-cpu16
16 linux-amd64-gpu-v100-latest-1
12 windows-amd64-cpu16

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

@miscco miscco merged commit 259887a into NVIDIA:main May 28, 2024
5 checks passed
@miscco miscco deleted the fix_thrust_unqualified_pow branch May 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: functional nvbug Has an associated internal NVIDIA NVBug. thrust For all items related to Thrust.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants