Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace typedef by alias declarations in CUB #1885

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Replace typedef by alias declarations in CUB #1885

merged 1 commit into from
Jun 24, 2024

Conversation

bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Jun 19, 2024 •
edited
Loading

This PR replaces (almost) all occurences of typedef by alias declarations in CUB.

This was done using a combination of:

  • clang-tidy modernize-use-using
  • regex replace: "typedef ([\w<>,:\s*&+:[].]+)\s+([\w_]+);" by "using $2 = $1;"
  • manual search and edits

Fixes a part of: #1747

@bernhardmgruber bernhardmgruber requested review from a team as code owners June 19, 2024 21:59
@bernhardmgruber bernhardmgruber marked this pull request as draft June 19, 2024 22:00
@bernhardmgruber bernhardmgruber changed the title Replace typedef by alias declarations Replace typedef by alias declarations in CUB Jun 19, 2024
@bernhardmgruber bernhardmgruber marked this pull request as ready for review June 19, 2024 22:18
@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label Jun 19, 2024
@bernhardmgruber
Replace typedef by alias declarations in CUB
9114e7b 
Using:
* clang-tidy modernize-use-using
* regex replace: "typedef ([\w<>,:\s*&+:\[\]\.]+)\s+([\w_]+);" by "using $2 = $1;"
* manual search and edits

Fixes a part of: NVIDIA#1747
@bernhardmgruber bernhardmgruber marked this pull request as draft June 19, 2024 23:41
@github-actions GitHub Actions
Copy link
Contributor

🟨 CI finished in 3h 08m: Pass: 99%/249 | Total: 2d 00h | Avg: 11m 48s | Max: 52m 53s | Hits: 82%/247587

  • 🟨 cub: Pass: 99%/131 | Total: 1d 08h | Avg: 14m 54s | Max: 52m 53s | Hits: 66%/108321

     
    🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  99%/123 | Total:  1d 07h | Avg: 15m 12s | Max: 52m 53s | Hits:  67%/101505
  🟩 arm64              Pass: 100%/8   | Total:  1h 21m | Avg: 10m 14s | Max: 10m 46s | Hits:  62%/6816  
🔍 ctk: 12.4 🔍
  🟩 11.1               Pass: 100%/15  | Total:  2h 56m | Avg: 11m 46s | Max: 49m 19s | Hits:  56%/11568 
  🟩 11.8               Pass: 100%/3   | Total: 31m 34s | Avg: 10m 31s | Max: 10m 46s | Hits:  61%/2556  
  🔍 12.4               Pass:  99%/113 | Total:  1d 05h | Avg: 15m 26s | Max: 52m 53s | Hits:  68%/94197 
🔍 cudacxx: nvcc12.4 🔍
  🟩 ClangCUDA17        Pass: 100%/2   | Total: 15m 34s | Avg:  7m 47s | Max:  8m 08s | Hits:  55%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 56m | Avg: 11m 46s | Max: 49m 19s | Hits:  56%/11568 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 31m 34s | Avg: 10m 31s | Max: 10m 46s | Hits:  61%/2556  
  🔍 nvcc12.4           Pass:  99%/111 | Total:  1d 04h | Avg: 15m 34s | Max: 52m 53s | Hits:  68%/92789 
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/2   | Total: 15m 34s | Avg:  7m 47s | Max:  8m 08s | Hits:  55%/1408  
  🔍 nvcc               Pass:  99%/129 | Total:  1d 08h | Avg: 15m 01s | Max: 52m 53s | Hits:  66%/106913
🔍 cxx: Clang17 🔍
  🟩 Clang9             Pass: 100%/6   | Total: 54m 53s | Avg:  9m 08s | Max:  9m 51s | Hits:  60%/4890  
  🟩 Clang10            Pass: 100%/3   | Total: 29m 41s | Avg:  9m 53s | Max: 10m 33s | Hits:  62%/2562  
  🟩 Clang11            Pass: 100%/4   | Total: 35m 03s | Avg:  8m 45s | Max:  9m 16s | Hits:  62%/3416  
  🟩 Clang12            Pass: 100%/4   | Total: 37m 08s | Avg:  9m 17s | Max:  9m 51s | Hits:  62%/3416  
  🟩 Clang13            Pass: 100%/4   | Total: 36m 06s | Avg:  9m 01s | Max:  9m 45s | Hits:  62%/3416  
  🟩 Clang14            Pass: 100%/4   | Total: 35m 07s | Avg:  8m 46s | Max:  9m 04s | Hits:  62%/3416  
  🟩 Clang15            Pass: 100%/4   | Total: 36m 35s | Avg:  9m 08s | Max:  9m 39s | Hits:  62%/3408  
  🟩 Clang16            Pass: 100%/4   | Total: 35m 36s | Avg:  8m 54s | Max:  9m 21s | Hits:  62%/3408  
  🔍 Clang17            Pass:  96%/26  | Total:  7h 37m | Avg: 17m 35s | Max: 32m 00s | Hits:  79%/21004 
  🟩 GCC6               Pass: 100%/2   | Total: 18m 36s | Avg:  9m 18s | Max:  9m 38s | Hits:  59%/1552  
  🟩 GCC7               Pass: 100%/6   | Total: 52m 42s | Avg:  8m 47s | Max:  9m 18s | Hits:  60%/4893  
  🟩 GCC8               Pass: 100%/6   | Total: 53m 46s | Avg:  8m 57s | Max:  9m 38s | Hits:  60%/4893  
  🟩 GCC9               Pass: 100%/6   | Total: 57m 28s | Avg:  9m 34s | Max: 11m 06s | Hits:  60%/4893  
  🟩 GCC10              Pass: 100%/4   | Total: 38m 23s | Avg:  9m 35s | Max: 10m 16s | Hits:  62%/3416  
  🟩 GCC11              Pass: 100%/7   | Total:  1h 07m | Avg:  9m 41s | Max: 10m 46s | Hits:  62%/5964  
  🟩 GCC12              Pass: 100%/4   | Total: 39m 22s | Avg:  9m 50s | Max: 10m 16s | Hits:  62%/3408  
  🟩 GCC13              Pass: 100%/28  | Total:  8h 58m | Avg: 19m 13s | Max: 44m 01s | Hits:  76%/23856 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 39m 19s | Avg: 13m 06s | Max: 13m 59s | Hits:  59%/2340  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 49m 19s | Avg: 49m 19s | Max: 49m 19s | Hits:  17%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 33m | Avg: 46m 34s | Max: 48m 42s | Hits:  18%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 27m | Avg: 49m 01s | Max: 52m 53s | Hits:  18%/2085  
🔍 cxx_family: Clang 🔍
  🔍 Clang              Pass:  98%/59  | Total: 12h 37m | Avg: 12m 50s | Max: 32m 00s | Hits:  69%/48936 
  🟩 GCC                Pass: 100%/63  | Total: 14h 26m | Avg: 13m 45s | Max: 44m 01s | Hits:  68%/52875 
  🟩 Intel              Pass: 100%/3   | Total: 39m 19s | Avg: 13m 06s | Max: 13m 59s | Hits:  59%/2340  
  🟩 MSVC               Pass: 100%/6   | Total:  4h 49m | Avg: 48m 15s | Max: 52m 53s | Hits:  18%/4170  
🔍 jobs: DeviceLaunch 🔍
  🟩 Build              Pass: 100%/99  | Total: 21h 35m | Avg: 13m 05s | Max: 52m 53s | Hits:  56%/81909 
  🔍 DeviceLaunch       Pass:  87%/8   | Total:  2h 40m | Avg: 20m 01s | Max: 44m 01s | Hits:  94%/5964  
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 16m | Avg: 17m 07s | Max: 21m 01s | Hits:  99%/6816  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 31m | Avg: 18m 57s | Max: 22m 31s | Hits:  99%/6816  
  🟩 TestGPU            Pass: 100%/8   | Total:  3h 27m | Avg: 25m 59s | Max: 35m 09s | Hits:  99%/6816  
🔍 std: 14 🔍
  🟩 11                 Pass: 100%/34  | Total:  7h 21m | Avg: 12m 59s | Max: 32m 31s | Hits:  68%/28539 
  🔍 14                 Pass:  97%/37  | Total:  9h 41m | Avg: 15m 43s | Max: 52m 53s | Hits:  64%/29772 
  🟩 17                 Pass: 100%/36  | Total:  8h 49m | Avg: 14m 42s | Max: 46m 24s | Hits:  66%/29857 
  🟩 20                 Pass: 100%/24  | Total:  6h 39m | Avg: 16m 39s | Max: 47m 47s | Hits:  68%/20153 
🟨 gpu
  🟨 v100               Pass:  99%/131 | Total:  1d 08h | Avg: 14m 54s | Max: 52m 53s | Hits:  66%/108321
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 31m 34s | Avg: 10m 31s | Max: 10m 46s | Hits:  61%/2556  
  🟩 90a                Pass: 100%/4   | Total: 23m 33s | Avg:  5m 53s | Max:  6m 07s | Hits:  62%/3408

  • 🟩 thrust: Pass: 100%/118 | Total: 16h 25m | Avg: 8m 21s | Max: 22m 39s | Hits: 94%/139266

     
    🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total: 15h 57m | Avg:  8m 42s | Max: 22m 39s | Hits:  93%/129822
  🟩 arm64              Pass: 100%/8   | Total: 27m 49s | Avg:  3m 28s | Max:  4m 00s | Hits:  99%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 01m | Avg:  4m 07s | Max: 14m 40s | Hits:  99%/17705 
  🟩 11.8               Pass: 100%/3   | Total: 11m 46s | Avg:  3m 55s | Max:  4m 06s | Hits:  99%/3543  
  🟩 12.4               Pass: 100%/100 | Total: 15h 12m | Avg:  9m 07s | Max: 22m 39s | Hits:  93%/118018
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 18s | Avg:  3m 39s | Max:  3m 42s | Hits: 100%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 01m | Avg:  4m 07s | Max: 14m 40s | Hits:  99%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 11m 46s | Avg:  3m 55s | Max:  4m 06s | Hits:  99%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total: 15h 04m | Avg:  9m 14s | Max: 22m 39s | Hits:  93%/115658
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 18s | Avg:  3m 39s | Max:  3m 42s | Hits: 100%/2360  
  🟩 nvcc               Pass: 100%/116 | Total: 16h 18m | Avg:  8m 26s | Max: 22m 39s | Hits:  94%/136906
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 55m 42s | Avg:  9m 17s | Max: 16m 47s | Hits:  89%/7080  
  🟩 Clang10            Pass: 100%/3   | Total: 19m 21s | Avg:  6m 27s | Max: 10m 27s | Hits:  95%/3540  
  🟩 Clang11            Pass: 100%/4   | Total: 31m 12s | Avg:  7m 48s | Max: 10m 07s | Hits:  90%/4720  
  🟩 Clang12            Pass: 100%/4   | Total: 38m 45s | Avg:  9m 41s | Max: 12m 07s | Hits:  88%/4720  
  🟩 Clang13            Pass: 100%/4   | Total: 40m 35s | Avg: 10m 08s | Max: 11m 53s | Hits:  84%/4720  
  🟩 Clang14            Pass: 100%/4   | Total: 47m 08s | Avg: 11m 47s | Max: 13m 06s | Hits:  81%/4720  
  🟩 Clang15            Pass: 100%/4   | Total: 44m 39s | Avg: 11m 09s | Max: 13m 09s | Hits:  82%/4720  
  🟩 Clang16            Pass: 100%/4   | Total: 53m 03s | Avg: 13m 15s | Max: 18m 22s | Hits:  80%/4720  
  🟩 Clang17            Pass: 100%/18  | Total:  2h 45m | Avg:  9m 12s | Max: 20m 14s | Hits:  94%/21240 
  🟩 GCC6               Pass: 100%/2   | Total:  6m 30s | Avg:  3m 15s | Max:  3m 16s | Hits:  99%/2360  
  🟩 GCC7               Pass: 100%/6   | Total: 21m 33s | Avg:  3m 35s | Max:  4m 05s | Hits:  99%/7086  
  🟩 GCC8               Pass: 100%/6   | Total: 20m 44s | Avg:  3m 27s | Max:  3m 40s | Hits:  99%/7086  
  🟩 GCC9               Pass: 100%/6   | Total: 33m 37s | Avg:  5m 36s | Max: 10m 22s | Hits:  95%/7086  
  🟩 GCC10              Pass: 100%/4   | Total: 15m 40s | Avg:  3m 55s | Max:  4m 21s | Hits:  99%/4724  
  🟩 GCC11              Pass: 100%/7   | Total: 27m 40s | Avg:  3m 57s | Max:  4m 06s | Hits:  99%/8267  
  🟩 GCC12              Pass: 100%/4   | Total: 16m 25s | Avg:  4m 06s | Max:  4m 26s | Hits:  99%/4724  
  🟩 GCC13              Pass: 100%/20  | Total:  3h 12m | Avg:  9m 37s | Max: 21m 22s | Hits:  95%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  5m 00s | Hits:  99%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 40s | Avg: 14m 40s | Max: 14m 40s | Hits:  98%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 51s | Avg: 12m 25s | Max: 12m 30s | Hits:  98%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 41m | Avg: 16m 57s | Max: 22m 39s | Hits:  98%/7056  
🟩 cxx_family
  🟩 Clang              Pass: 100%/51  | Total:  8h 16m | Avg:  9m 43s | Max: 20m 14s | Hits:  89%/60180 
  🟩 GCC                Pass: 100%/55  | Total:  5h 34m | Avg:  6m 04s | Max: 21m 22s | Hits:  97%/64953 
  🟩 Intel              Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  5m 00s | Hits:  99%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  2h 21m | Avg: 15m 41s | Max: 22m 39s | Hits:  98%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 16h 25m | Avg:  8m 21s | Max: 22m 39s | Hits:  94%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total: 12h 38m | Avg:  7m 39s | Max: 21m 22s | Hits:  93%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 54m | Avg: 10m 23s | Max: 22m 39s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  1h 52m | Avg: 14m 04s | Max: 18m 32s | Hits:  99%/9444  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 11m 46s | Avg:  3m 55s | Max:  4m 06s | Hits:  99%/3543  
  🟩 90a                Pass: 100%/4   | Total: 13m 30s | Avg:  3m 22s | Max:  3m 27s | Hits:  99%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 02m | Avg:  6m 04s | Max: 15m 28s | Hits:  96%/35418 
  🟩 14                 Pass: 100%/34  | Total:  4h 45m | Avg:  8m 23s | Max: 20m 22s | Hits:  94%/40122 
  🟩 17                 Pass: 100%/33  | Total:  4h 53m | Avg:  8m 53s | Max: 22m 39s | Hits:  93%/38946 
  🟩 20                 Pass: 100%/21  | Total:  3h 44m | Avg: 10m 41s | Max: 21m 08s | Hits:  92%/24780

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

🏃‍ Runner counts (total jobs: 249)
# Runner
178 linux-amd64-cpu16
40 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber marked this pull request as ready for review June 23, 2024 22:13
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 3d 22h: Pass: 100%/249 | Total: 2d 01h | Avg: 11m 50s | Max: 52m 53s | Hits: 82%/248439

  • 🟩 cub: Pass: 100%/131 | Total: 1d 08h | Avg: 14m 58s | Max: 52m 53s | Hits: 67%/109173

     
    🟩 cpu
  🟩 amd64              Pass: 100%/123 | Total:  1d 07h | Avg: 15m 17s | Max: 52m 53s | Hits:  67%/102357
  🟩 arm64              Pass: 100%/8   | Total:  1h 21m | Avg: 10m 14s | Max: 10m 46s | Hits:  62%/6816  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  2h 56m | Avg: 11m 46s | Max: 49m 19s | Hits:  56%/11568 
  🟩 11.8               Pass: 100%/3   | Total: 31m 34s | Avg: 10m 31s | Max: 10m 46s | Hits:  61%/2556  
  🟩 12.4               Pass: 100%/113 | Total:  1d 05h | Avg: 15m 31s | Max: 52m 53s | Hits:  68%/95049 
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total: 15m 34s | Avg:  7m 47s | Max:  8m 08s | Hits:  55%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  2h 56m | Avg: 11m 46s | Max: 49m 19s | Hits:  56%/11568 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 31m 34s | Avg: 10m 31s | Max: 10m 46s | Hits:  61%/2556  
  🟩 nvcc12.4           Pass: 100%/111 | Total:  1d 04h | Avg: 15m 39s | Max: 52m 53s | Hits:  68%/93641 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 15m 34s | Avg:  7m 47s | Max:  8m 08s | Hits:  55%/1408  
  🟩 nvcc               Pass: 100%/129 | Total:  1d 08h | Avg: 15m 05s | Max: 52m 53s | Hits:  67%/107765
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 54m 53s | Avg:  9m 08s | Max:  9m 51s | Hits:  60%/4890  
  🟩 Clang10            Pass: 100%/3   | Total: 29m 41s | Avg:  9m 53s | Max: 10m 33s | Hits:  62%/2562  
  🟩 Clang11            Pass: 100%/4   | Total: 35m 03s | Avg:  8m 45s | Max:  9m 16s | Hits:  62%/3416  
  🟩 Clang12            Pass: 100%/4   | Total: 37m 08s | Avg:  9m 17s | Max:  9m 51s | Hits:  62%/3416  
  🟩 Clang13            Pass: 100%/4   | Total: 36m 06s | Avg:  9m 01s | Max:  9m 45s | Hits:  62%/3416  
  🟩 Clang14            Pass: 100%/4   | Total: 35m 07s | Avg:  8m 46s | Max:  9m 04s | Hits:  62%/3416  
  🟩 Clang15            Pass: 100%/4   | Total: 36m 35s | Avg:  9m 08s | Max:  9m 39s | Hits:  62%/3408  
  🟩 Clang16            Pass: 100%/4   | Total: 35m 36s | Avg:  8m 54s | Max:  9m 21s | Hits:  62%/3408  
  🟩 Clang17            Pass: 100%/26  | Total:  7h 47m | Avg: 17m 58s | Max: 32m 00s | Hits:  80%/21856 
  🟩 GCC6               Pass: 100%/2   | Total: 18m 36s | Avg:  9m 18s | Max:  9m 38s | Hits:  59%/1552  
  🟩 GCC7               Pass: 100%/6   | Total: 52m 42s | Avg:  8m 47s | Max:  9m 18s | Hits:  60%/4893  
  🟩 GCC8               Pass: 100%/6   | Total: 53m 46s | Avg:  8m 57s | Max:  9m 38s | Hits:  60%/4893  
  🟩 GCC9               Pass: 100%/6   | Total: 57m 28s | Avg:  9m 34s | Max: 11m 06s | Hits:  60%/4893  
  🟩 GCC10              Pass: 100%/4   | Total: 38m 23s | Avg:  9m 35s | Max: 10m 16s | Hits:  62%/3416  
  🟩 GCC11              Pass: 100%/7   | Total:  1h 07m | Avg:  9m 41s | Max: 10m 46s | Hits:  62%/5964  
  🟩 GCC12              Pass: 100%/4   | Total: 39m 22s | Avg:  9m 50s | Max: 10m 16s | Hits:  62%/3408  
  🟩 GCC13              Pass: 100%/28  | Total:  8h 58m | Avg: 19m 13s | Max: 44m 01s | Hits:  76%/23856 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 39m 19s | Avg: 13m 06s | Max: 13m 59s | Hits:  59%/2340  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 49m 19s | Avg: 49m 19s | Max: 49m 19s | Hits:  17%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 33m | Avg: 46m 34s | Max: 48m 42s | Hits:  18%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 27m | Avg: 49m 01s | Max: 52m 53s | Hits:  18%/2085  
🟩 cxx_family
  🟩 Clang              Pass: 100%/59  | Total: 12h 47m | Avg: 13m 00s | Max: 32m 00s | Hits:  70%/49788 
  🟩 GCC                Pass: 100%/63  | Total: 14h 26m | Avg: 13m 45s | Max: 44m 01s | Hits:  68%/52875 
  🟩 Intel              Pass: 100%/3   | Total: 39m 19s | Avg: 13m 06s | Max: 13m 59s | Hits:  59%/2340  
  🟩 MSVC               Pass: 100%/6   | Total:  4h 49m | Avg: 48m 15s | Max: 52m 53s | Hits:  18%/4170  
🟩 gpu
  🟩 v100               Pass: 100%/131 | Total:  1d 08h | Avg: 14m 58s | Max: 52m 53s | Hits:  67%/109173
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total: 21h 35m | Avg: 13m 05s | Max: 52m 53s | Hits:  56%/81909 
  🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 50m | Avg: 21m 15s | Max: 44m 01s | Hits:  94%/6816  
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 16m | Avg: 17m 07s | Max: 21m 01s | Hits:  99%/6816  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 31m | Avg: 18m 57s | Max: 22m 31s | Hits:  99%/6816  
  🟩 TestGPU            Pass: 100%/8   | Total:  3h 27m | Avg: 25m 59s | Max: 35m 09s | Hits:  99%/6816  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 31m 34s | Avg: 10m 31s | Max: 10m 46s | Hits:  61%/2556  
  🟩 90a                Pass: 100%/4   | Total: 23m 33s | Avg:  5m 53s | Max:  6m 07s | Hits:  62%/3408  
🟩 std
  🟩 11                 Pass: 100%/34  | Total:  7h 21m | Avg: 12m 59s | Max: 32m 31s | Hits:  68%/28539 
  🟩 14                 Pass: 100%/37  | Total:  9h 51m | Avg: 15m 59s | Max: 52m 53s | Hits:  65%/30624 
  🟩 17                 Pass: 100%/36  | Total:  8h 49m | Avg: 14m 42s | Max: 46m 24s | Hits:  66%/29857 
  🟩 20                 Pass: 100%/24  | Total:  6h 39m | Avg: 16m 39s | Max: 47m 47s | Hits:  68%/20153

  • 🟩 thrust: Pass: 100%/118 | Total: 16h 25m | Avg: 8m 21s | Max: 22m 39s | Hits: 94%/139266

     
    🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total: 15h 57m | Avg:  8m 42s | Max: 22m 39s | Hits:  93%/129822
  🟩 arm64              Pass: 100%/8   | Total: 27m 49s | Avg:  3m 28s | Max:  4m 00s | Hits:  99%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 01m | Avg:  4m 07s | Max: 14m 40s | Hits:  99%/17705 
  🟩 11.8               Pass: 100%/3   | Total: 11m 46s | Avg:  3m 55s | Max:  4m 06s | Hits:  99%/3543  
  🟩 12.4               Pass: 100%/100 | Total: 15h 12m | Avg:  9m 07s | Max: 22m 39s | Hits:  93%/118018
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 18s | Avg:  3m 39s | Max:  3m 42s | Hits: 100%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 01m | Avg:  4m 07s | Max: 14m 40s | Hits:  99%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 11m 46s | Avg:  3m 55s | Max:  4m 06s | Hits:  99%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total: 15h 04m | Avg:  9m 14s | Max: 22m 39s | Hits:  93%/115658
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 18s | Avg:  3m 39s | Max:  3m 42s | Hits: 100%/2360  
  🟩 nvcc               Pass: 100%/116 | Total: 16h 18m | Avg:  8m 26s | Max: 22m 39s | Hits:  94%/136906
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 55m 42s | Avg:  9m 17s | Max: 16m 47s | Hits:  89%/7080  
  🟩 Clang10            Pass: 100%/3   | Total: 19m 21s | Avg:  6m 27s | Max: 10m 27s | Hits:  95%/3540  
  🟩 Clang11            Pass: 100%/4   | Total: 31m 12s | Avg:  7m 48s | Max: 10m 07s | Hits:  90%/4720  
  🟩 Clang12            Pass: 100%/4   | Total: 38m 45s | Avg:  9m 41s | Max: 12m 07s | Hits:  88%/4720  
  🟩 Clang13            Pass: 100%/4   | Total: 40m 35s | Avg: 10m 08s | Max: 11m 53s | Hits:  84%/4720  
  🟩 Clang14            Pass: 100%/4   | Total: 47m 08s | Avg: 11m 47s | Max: 13m 06s | Hits:  81%/4720  
  🟩 Clang15            Pass: 100%/4   | Total: 44m 39s | Avg: 11m 09s | Max: 13m 09s | Hits:  82%/4720  
  🟩 Clang16            Pass: 100%/4   | Total: 53m 03s | Avg: 13m 15s | Max: 18m 22s | Hits:  80%/4720  
  🟩 Clang17            Pass: 100%/18  | Total:  2h 45m | Avg:  9m 12s | Max: 20m 14s | Hits:  94%/21240 
  🟩 GCC6               Pass: 100%/2   | Total:  6m 30s | Avg:  3m 15s | Max:  3m 16s | Hits:  99%/2360  
  🟩 GCC7               Pass: 100%/6   | Total: 21m 33s | Avg:  3m 35s | Max:  4m 05s | Hits:  99%/7086  
  🟩 GCC8               Pass: 100%/6   | Total: 20m 44s | Avg:  3m 27s | Max:  3m 40s | Hits:  99%/7086  
  🟩 GCC9               Pass: 100%/6   | Total: 33m 37s | Avg:  5m 36s | Max: 10m 22s | Hits:  95%/7086  
  🟩 GCC10              Pass: 100%/4   | Total: 15m 40s | Avg:  3m 55s | Max:  4m 21s | Hits:  99%/4724  
  🟩 GCC11              Pass: 100%/7   | Total: 27m 40s | Avg:  3m 57s | Max:  4m 06s | Hits:  99%/8267  
  🟩 GCC12              Pass: 100%/4   | Total: 16m 25s | Avg:  4m 06s | Max:  4m 26s | Hits:  99%/4724  
  🟩 GCC13              Pass: 100%/20  | Total:  3h 12m | Avg:  9m 37s | Max: 21m 22s | Hits:  95%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  5m 00s | Hits:  99%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 40s | Avg: 14m 40s | Max: 14m 40s | Hits:  98%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 24m 51s | Avg: 12m 25s | Max: 12m 30s | Hits:  98%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 41m | Avg: 16m 57s | Max: 22m 39s | Hits:  98%/7056  
🟩 cxx_family
  🟩 Clang              Pass: 100%/51  | Total:  8h 16m | Avg:  9m 43s | Max: 20m 14s | Hits:  89%/60180 
  🟩 GCC                Pass: 100%/55  | Total:  5h 34m | Avg:  6m 04s | Max: 21m 22s | Hits:  97%/64953 
  🟩 Intel              Pass: 100%/3   | Total: 13m 57s | Avg:  4m 39s | Max:  5m 00s | Hits:  99%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  2h 21m | Avg: 15m 41s | Max: 22m 39s | Hits:  98%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 16h 25m | Avg:  8m 21s | Max: 22m 39s | Hits:  94%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total: 12h 38m | Avg:  7m 39s | Max: 21m 22s | Hits:  93%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 54m | Avg: 10m 23s | Max: 22m 39s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  1h 52m | Avg: 14m 04s | Max: 18m 32s | Hits:  99%/9444  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 11m 46s | Avg:  3m 55s | Max:  4m 06s | Hits:  99%/3543  
  🟩 90a                Pass: 100%/4   | Total: 13m 30s | Avg:  3m 22s | Max:  3m 27s | Hits:  99%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  3h 02m | Avg:  6m 04s | Max: 15m 28s | Hits:  96%/35418 
  🟩 14                 Pass: 100%/34  | Total:  4h 45m | Avg:  8m 23s | Max: 20m 22s | Hits:  94%/40122 
  🟩 17                 Pass: 100%/33  | Total:  4h 53m | Avg:  8m 53s | Max: 22m 39s | Hits:  93%/38946 
  🟩 20                 Pass: 100%/21  | Total:  3h 44m | Avg: 10m 41s | Max: 21m 08s | Hits:  92%/24780

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

🏃‍ Runner counts (total jobs: 249)
# Runner
178 linux-amd64-cpu16
40 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

bernhardmgruber
bernhardmgruber commented Jun 24, 2024
View reviewed changes
cub/cub/util_type.cuh
Comment on lines +357 to +358
typedef __align__(b) t Type; \
/* TODO(bgruber): rewriting the above to using Type __align__(b) = t; does not compile :S */ \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typedef I couldn't rewrite. GCC/clang would accept an alignas for a using declaration, but I could not find a combination that works for nvcc.

@bernhardmgruber bernhardmgruber merged commit 54fd507 into NVIDIA:main Jun 24, 2024
265 checks passed
@bernhardmgruber bernhardmgruber deleted the using branch June 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@griwes griwes Awaiting requested review from griwes griwes was automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
cub For all items related to CUB
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @elstehle