Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation generation for thrust::pair #1976

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix documentation generation for thrust::pair #1976

merged 1 commit into from
Jul 11, 2024

Conversation

bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Jul 11, 2024 •
edited
Loading

Fixes: #1975

I checked the generated documentation locally, and it generates the same page as the current online documentation:

image

@bernhardmgruber bernhardmgruber added the doc Documentation-related items. label Jul 11, 2024
@bernhardmgruber bernhardmgruber marked this pull request as ready for review July 11, 2024 08:19
@bernhardmgruber bernhardmgruber requested review from a team as code owners July 11, 2024 08:19
elstehle
elstehle approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@elstehle elstehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bernhardmgruber bernhardmgruber merged commit 424a0fd into NVIDIA:main Jul 11, 2024
20 checks passed
@bernhardmgruber bernhardmgruber deleted the fix_pair_docs branch July 11, 2024 08:23
@bernhardmgruber bernhardmgruber mentioned this pull request Jul 11, 2024
Merged
2 tasks
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Jul 17, 2024
@bernhardmgruber @pciolkosz
Fix documentation generation for thrust::pair (NVIDIA#1976)
8447e11 
Fixes: NVIDIA#1975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from NVIDIA/cccl-thrust-codeowners

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
doc Documentation-related items.
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation build fails
2 participants
@bernhardmgruber @elstehle