Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop zipped_binary_op #1988

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

bernhardmgruber
Copy link
Contributor

This PR drops thrust::detail::zipped_binary_op, which was a less generic version of thrust::zip_function.

SASS of thrust.bench.inner_product stayed the same.

@bernhardmgruber bernhardmgruber added the thrust For all items related to Thrust. label Jul 15, 2024
@bernhardmgruber bernhardmgruber marked this pull request as ready for review July 15, 2024 08:02
@bernhardmgruber bernhardmgruber requested review from a team as code owners July 15, 2024 08:02
Copy link
Contributor

🟩 CI finished in 3h 33m: Pass: 100%/250 | Total: 4d 22h | Avg: 28m 31s | Max: 58m 57s | Hits: 51%/248216
  • 🟩 cub: Pass: 100%/131 | Total: 2d 15h | Avg: 29m 13s | Max: 45m 42s | Hits: 70%/109304

    🟩 cpu
      🟩 amd64              Pass: 100%/123 | Total:  2d 11h | Avg: 28m 53s | Max: 45m 42s | Hits:  71%/102480
      🟩 arm64              Pass: 100%/8   | Total:  4h 34m | Avg: 34m 20s | Max: 36m 54s | Hits:  60%/6824  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  7h 25m | Avg: 29m 43s | Max: 45m 42s | Hits:  61%/11583 
      🟩 11.8               Pass: 100%/3   | Total:  2h 08m | Avg: 42m 45s | Max: 44m 00s | Hits:  60%/2559  
      🟩 12.5               Pass: 100%/113 | Total:  2d 06h | Avg: 28m 47s | Max: 44m 53s | Hits:  72%/95162 
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total: 39m 33s | Avg: 19m 46s | Max: 19m 51s | Hits:  66%/1410  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 25m | Avg: 29m 43s | Max: 45m 42s | Hits:  61%/11583 
      🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 08m | Avg: 42m 45s | Max: 44m 00s | Hits:  60%/2559  
      🟩 nvcc12.5           Pass: 100%/111 | Total:  2d 05h | Avg: 28m 57s | Max: 44m 53s | Hits:  72%/93752 
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total: 39m 33s | Avg: 19m 46s | Max: 19m 51s | Hits:  66%/1410  
      🟩 nvcc               Pass: 100%/129 | Total:  2d 15h | Avg: 29m 22s | Max: 45m 42s | Hits:  70%/107894
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total:  3h 00m | Avg: 30m 02s | Max: 34m 17s | Hits:  61%/4896  
      🟩 Clang10            Pass: 100%/3   | Total:  1h 43m | Avg: 34m 24s | Max: 35m 28s | Hits:  61%/2565  
      🟩 Clang11            Pass: 100%/4   | Total:  2h 11m | Avg: 32m 53s | Max: 33m 52s | Hits:  61%/3420  
      🟩 Clang12            Pass: 100%/4   | Total:  2h 13m | Avg: 33m 23s | Max: 35m 50s | Hits:  61%/3420  
      🟩 Clang13            Pass: 100%/4   | Total:  2h 07m | Avg: 31m 55s | Max: 32m 23s | Hits:  61%/3420  
      🟩 Clang14            Pass: 100%/4   | Total:  2h 09m | Avg: 32m 19s | Max: 33m 02s | Hits:  61%/3420  
      🟩 Clang15            Pass: 100%/4   | Total:  2h 13m | Avg: 33m 21s | Max: 35m 06s | Hits:  61%/3412  
      🟩 Clang16            Pass: 100%/4   | Total:  2h 12m | Avg: 33m 00s | Max: 34m 42s | Hits:  61%/3412  
      🟩 Clang17            Pass: 100%/26  | Total:  9h 43m | Avg: 22m 26s | Max: 33m 58s | Hits:  85%/21882 
      🟩 GCC6               Pass: 100%/2   | Total: 57m 02s | Avg: 28m 31s | Max: 28m 41s | Hits:  60%/1554  
      🟩 GCC7               Pass: 100%/6   | Total:  3h 04m | Avg: 30m 42s | Max: 32m 45s | Hits:  60%/4899  
      🟩 GCC8               Pass: 100%/6   | Total:  3h 04m | Avg: 30m 48s | Max: 33m 05s | Hits:  60%/4899  
      🟩 GCC9               Pass: 100%/6   | Total:  3h 10m | Avg: 31m 40s | Max: 35m 37s | Hits:  60%/4899  
      🟩 GCC10              Pass: 100%/4   | Total:  2h 19m | Avg: 34m 48s | Max: 35m 39s | Hits:  60%/3420  
      🟩 GCC11              Pass: 100%/7   | Total:  4h 26m | Avg: 38m 03s | Max: 44m 00s | Hits:  60%/5971  
      🟩 GCC12              Pass: 100%/4   | Total:  2h 18m | Avg: 34m 34s | Max: 35m 57s | Hits:  60%/3412  
      🟩 GCC13              Pass: 100%/28  | Total: 10h 46m | Avg: 23m 04s | Max: 36m 54s | Hits:  82%/23884 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 51m | Avg: 37m 15s | Max: 37m 59s | Hits:  61%/2343  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 45m 42s | Avg: 45m 42s | Max: 45m 42s | Hits:  65%/696   
      🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 20m | Avg: 40m 25s | Max: 42m 25s | Hits:  65%/1392  
      🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 09m | Avg: 43m 00s | Max: 44m 53s | Hits:  65%/2088  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/59  | Total:  1d 03h | Avg: 28m 02s | Max: 35m 50s | Hits:  72%/49847 
      🟩 GCC                Pass: 100%/63  | Total:  1d 06h | Avg: 28m 40s | Max: 44m 00s | Hits:  70%/52938 
      🟩 Intel              Pass: 100%/3   | Total:  1h 51m | Avg: 37m 15s | Max: 37m 59s | Hits:  61%/2343  
      🟩 MSVC               Pass: 100%/6   | Total:  4h 15m | Avg: 42m 35s | Max: 45m 42s | Hits:  65%/4176  
    🟩 gpu
      🟩 v100               Pass: 100%/131 | Total:  2d 15h | Avg: 29m 13s | Max: 45m 42s | Hits:  70%/109304
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  2d 06h | Avg: 32m 51s | Max: 45m 42s | Hits:  61%/82008 
      🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 06m | Avg: 15m 48s | Max: 17m 35s | Hits:  99%/6824  
      🟩 GraphCapture       Pass: 100%/8   | Total:  2h 00m | Avg: 15m 06s | Max: 18m 02s | Hits:  99%/6824  
      🟩 HostLaunch         Pass: 100%/8   | Total:  2h 09m | Avg: 16m 12s | Max: 20m 00s | Hits:  99%/6824  
      🟩 TestGPU            Pass: 100%/8   | Total:  3h 17m | Avg: 24m 41s | Max: 30m 54s | Hits:  99%/6824  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 08m | Avg: 42m 45s | Max: 44m 00s | Hits:  60%/2559  
      🟩 90a                Pass: 100%/4   | Total:  1h 13m | Avg: 18m 27s | Max: 19m 27s | Hits:  60%/3412  
    🟩 std
      🟩 11                 Pass: 100%/34  | Total: 16h 07m | Avg: 28m 27s | Max: 41m 28s | Hits:  70%/28573 
      🟩 14                 Pass: 100%/37  | Total: 18h 41m | Avg: 30m 19s | Max: 45m 42s | Hits:  69%/30661 
      🟩 17                 Pass: 100%/36  | Total: 17h 45m | Avg: 29m 35s | Max: 42m 47s | Hits:  70%/29893 
      🟩 20                 Pass: 100%/24  | Total: 11h 13m | Avg: 28m 04s | Max: 44m 53s | Hits:  74%/20177 
    
  • 🟩 thrust: Pass: 100%/118 | Total: 2d 06h | Avg: 27m 54s | Max: 58m 57s | Hits: 35%/138912

    🟩 cpu
      🟩 amd64              Pass: 100%/110 | Total:  2d 02h | Avg: 27m 44s | Max: 58m 57s | Hits:  36%/129492
      🟩 arm64              Pass: 100%/8   | Total:  4h 01m | Avg: 30m 10s | Max: 34m 08s | Hits:  19%/9420  
    🟩 ctk
      🟩 11.1               Pass: 100%/15  | Total:  6h 57m | Avg: 27m 50s | Max: 52m 55s | Hits:  19%/17660 
      🟩 11.8               Pass: 100%/3   | Total:  1h 57m | Avg: 39m 00s | Max: 42m 27s | Hits:  20%/3534  
      🟩 12.5               Pass: 100%/100 | Total:  1d 21h | Avg: 27m 34s | Max: 58m 57s | Hits:  38%/117718
    🟩 cudacxx
      🟩 ClangCUDA17        Pass: 100%/2   | Total: 58m 53s | Avg: 29m 26s | Max: 29m 52s | Hits:  19%/2354  
      🟩 nvcc11.1           Pass: 100%/15  | Total:  6h 57m | Avg: 27m 50s | Max: 52m 55s | Hits:  19%/17660 
      🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 57m | Avg: 39m 00s | Max: 42m 27s | Hits:  20%/3534  
      🟩 nvcc12.5           Pass: 100%/98  | Total:  1d 20h | Avg: 27m 32s | Max: 58m 57s | Hits:  38%/115364
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total: 58m 53s | Avg: 29m 26s | Max: 29m 52s | Hits:  19%/2354  
      🟩 nvcc               Pass: 100%/116 | Total:  2d 05h | Avg: 27m 52s | Max: 58m 57s | Hits:  35%/136558
    🟩 cxx
      🟩 Clang9             Pass: 100%/6   | Total:  2h 42m | Avg: 27m 07s | Max: 31m 26s | Hits:  20%/7062  
      🟩 Clang10            Pass: 100%/3   | Total:  1h 34m | Avg: 31m 25s | Max: 33m 50s | Hits:  20%/3531  
      🟩 Clang11            Pass: 100%/4   | Total:  2h 00m | Avg: 30m 08s | Max: 34m 13s | Hits:  19%/4708  
      🟩 Clang12            Pass: 100%/4   | Total:  1h 58m | Avg: 29m 39s | Max: 31m 43s | Hits:  19%/4708  
      🟩 Clang13            Pass: 100%/4   | Total:  2h 01m | Avg: 30m 20s | Max: 32m 24s | Hits:  19%/4708  
      🟩 Clang14            Pass: 100%/4   | Total:  1h 58m | Avg: 29m 38s | Max: 32m 05s | Hits:  19%/4708  
      🟩 Clang15            Pass: 100%/4   | Total:  2h 04m | Avg: 31m 02s | Max: 34m 36s | Hits:  19%/4708  
      🟩 Clang16            Pass: 100%/4   | Total:  2h 00m | Avg: 30m 03s | Max: 31m 17s | Hits:  19%/4708  
      🟩 Clang17            Pass: 100%/18  | Total:  6h 09m | Avg: 20m 31s | Max: 34m 08s | Hits:  56%/21186 
      🟩 GCC6               Pass: 100%/2   | Total: 52m 29s | Avg: 26m 14s | Max: 27m 17s | Hits:  20%/2354  
      🟩 GCC7               Pass: 100%/6   | Total:  2h 45m | Avg: 27m 37s | Max: 33m 38s | Hits:  20%/7068  
      🟩 GCC8               Pass: 100%/6   | Total:  2h 47m | Avg: 27m 54s | Max: 31m 24s | Hits:  20%/7068  
      🟩 GCC9               Pass: 100%/6   | Total:  2h 56m | Avg: 29m 27s | Max: 33m 51s | Hits:  20%/7068  
      🟩 GCC10              Pass: 100%/4   | Total:  2h 06m | Avg: 31m 39s | Max: 34m 58s | Hits:  19%/4712  
      🟩 GCC11              Pass: 100%/7   | Total:  3h 51m | Avg: 33m 08s | Max: 42m 27s | Hits:  38%/8246  
      🟩 GCC12              Pass: 100%/4   | Total:  2h 07m | Avg: 31m 57s | Max: 34m 36s | Hits:  19%/4712  
      🟩 GCC13              Pass: 100%/20  | Total:  6h 22m | Avg: 19m 06s | Max: 32m 22s | Hits:  60%/23560 
      🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 01m | Avg: 40m 24s | Max: 44m 59s | Hits:  20%/3540  
      🟩 MSVC14.16          Pass: 100%/1   | Total: 52m 55s | Avg: 52m 55s | Max: 52m 55s | Hits:  17%/1173  
      🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 53m | Avg: 56m 59s | Max: 57m 25s | Hits:  17%/2346  
      🟩 MSVC14.39          Pass: 100%/6   | Total:  3h 43m | Avg: 37m 18s | Max: 58m 57s | Hits:  58%/7038  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/51  | Total: 22h 29m | Avg: 26m 28s | Max: 34m 36s | Hits:  32%/60027 
      🟩 GCC                Pass: 100%/55  | Total: 23h 50m | Avg: 26m 01s | Max: 42m 27s | Hits:  37%/64788 
      🟩 Intel              Pass: 100%/3   | Total:  2h 01m | Avg: 40m 24s | Max: 44m 59s | Hits:  20%/3540  
      🟩 MSVC               Pass: 100%/9   | Total:  6h 30m | Avg: 43m 24s | Max: 58m 57s | Hits:  44%/10557 
    🟩 gpu
      🟩 v100               Pass: 100%/118 | Total:  2d 06h | Avg: 27m 54s | Max: 58m 57s | Hits:  35%/138912
    🟩 jobs
      🟩 Build              Pass: 100%/99  | Total:  2d 03h | Avg: 31m 14s | Max: 58m 57s | Hits:  23%/116553
      🟩 TestCPU            Pass: 100%/11  | Total:  1h 41m | Avg:  9m 10s | Max: 18m 25s | Hits:  99%/12939 
      🟩 TestGPU            Pass: 100%/8   | Total:  1h 38m | Avg: 12m 18s | Max: 14m 02s | Hits:  99%/9420  
    🟩 sm
      🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 57m | Avg: 39m 00s | Max: 42m 27s | Hits:  20%/3534  
      🟩 90a                Pass: 100%/4   | Total:  1h 16m | Avg: 19m 09s | Max: 22m 03s | Hits:  19%/4712  
    🟩 std
      🟩 11                 Pass: 100%/30  | Total: 11h 44m | Avg: 23m 28s | Max: 35m 12s | Hits:  35%/35328 
      🟩 14                 Pass: 100%/34  | Total: 16h 51m | Avg: 29m 45s | Max: 56m 34s | Hits:  33%/40020 
      🟩 17                 Pass: 100%/33  | Total: 16h 30m | Avg: 30m 00s | Max: 58m 26s | Hits:  34%/38847 
      🟩 20                 Pass: 100%/21  | Total:  9h 46m | Avg: 27m 55s | Max: 58m 57s | Hits:  40%/24717 
    
  • 🟩 pycuda: Pass: 100%/1 | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s

    🟩 cpu
      🟩 amd64              Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 ctk
      🟩 12.5               Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 cudacxx
      🟩 nvcc12.5           Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 cxx
      🟩 GCC13              Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 cxx_family
      🟩 GCC                Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 gpu
      🟩 v100               Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    🟩 jobs
      🟩 Test               Pass: 100%/1   | Total: 11m 54s | Avg: 11m 54s | Max: 11m 54s
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
pycuda

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- pycuda

🏃‍ Runner counts (total jobs: 250)

# Runner
178 linux-amd64-cpu16
41 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber merged commit be91914 into NVIDIA:main Jul 17, 2024
265 checks passed
@bernhardmgruber bernhardmgruber deleted the zipped_bin_op branch July 17, 2024 13:18
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thrust For all items related to Thrust.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants