Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ::result_type for partial sums in TBB reduce_by_key #1998

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Avoid ::result_type for partial sums in TBB reduce_by_key #1998

merged 5 commits into from
Jul 26, 2024

Commits on Jul 25, 2024

  1. Use value iterator's value type for partial sums in TBB reduce_by_key 

    This allows us to get rid of partial_sum_type, which still uses the C++11-deprecated function object API ::result_type.
    @bernhardmgruber
    bernhardmgruber committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    26b39fe View commit details
    Browse the repository at this point in the history

  2. Address reviewer feedback

    @bernhardmgruber
    bernhardmgruber committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    51187b2 View commit details
    Browse the repository at this point in the history

  3. Address feedback from code review hour

    @bernhardmgruber
    bernhardmgruber committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0ed0a51 View commit details
    Browse the repository at this point in the history

  4. Apply feedback from georgii 

    Co-authored-by: Georgii Evtushenko <[email protected]>
    @bernhardmgruber @gevtushenko
    bernhardmgruber and gevtushenko committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d59607b View commit details
    Browse the repository at this point in the history

  5. Remove unused header

    @bernhardmgruber
    bernhardmgruber committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    db60bcc View commit details
    Browse the repository at this point in the history