Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify some pointer traits #2020

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Simplify some pointer traits #2020

merged 1 commit into from
Jul 23, 2024

Conversation

bernhardmgruber
Copy link
Contributor

This PR simplifies some pointer traits in Thrust.

@bernhardmgruber bernhardmgruber added the thrust For all items related to Thrust. label Jul 22, 2024
@bernhardmgruber bernhardmgruber marked this pull request as ready for review July 22, 2024 18:57
@bernhardmgruber bernhardmgruber requested review from a team as code owners July 22, 2024 18:57
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 6h 59m: Pass: 100%/250 | Total: 5d 03h | Avg: 29m 41s | Max: 1h 05m | Hits: 46%/248341

  • 🟩 cub: Pass: 100%/131 | Total: 2d 18h | Avg: 30m 34s | Max: 48m 59s | Hits: 67%/109429

     
    🟩 cpu
  🟩 amd64              Pass: 100%/123 | Total:  2d 14h | Avg: 30m 15s | Max: 48m 59s | Hits:  68%/102597
  🟩 arm64              Pass: 100%/8   | Total:  4h 45m | Avg: 35m 39s | Max: 40m 10s | Hits:  56%/6832  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 37m | Avg: 30m 28s | Max: 46m 40s | Hits:  56%/11598 
  🟩 11.8               Pass: 100%/3   | Total:  2h 17m | Avg: 45m 44s | Max: 48m 59s | Hits:  56%/2562  
  🟩 12.5               Pass: 100%/113 | Total:  2d 08h | Avg: 30m 11s | Max: 47m 56s | Hits:  69%/95269 
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total: 42m 56s | Avg: 21m 28s | Max: 23m 17s | Hits:  61%/1412  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 37m | Avg: 30m 28s | Max: 46m 40s | Hits:  56%/11598 
  🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 17m | Avg: 45m 44s | Max: 48m 59s | Hits:  56%/2562  
  🟩 nvcc12.5           Pass: 100%/111 | Total:  2d 08h | Avg: 30m 20s | Max: 47m 56s | Hits:  69%/93857 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 42m 56s | Avg: 21m 28s | Max: 23m 17s | Hits:  61%/1412  
  🟩 nvcc               Pass: 100%/129 | Total:  2d 18h | Avg: 30m 43s | Max: 48m 59s | Hits:  67%/108017
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  3h 08m | Avg: 31m 23s | Max: 36m 09s | Hits:  56%/4902  
  🟩 Clang10            Pass: 100%/3   | Total:  1h 43m | Avg: 34m 27s | Max: 36m 11s | Hits:  57%/2568  
  🟩 Clang11            Pass: 100%/4   | Total:  2h 17m | Avg: 34m 24s | Max: 37m 01s | Hits:  57%/3424  
  🟩 Clang12            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 54s | Max: 35m 27s | Hits:  57%/3424  
  🟩 Clang13            Pass: 100%/4   | Total:  2h 17m | Avg: 34m 21s | Max: 35m 31s | Hits:  57%/3424  
  🟩 Clang14            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 59s | Max: 37m 17s | Hits:  57%/3424  
  🟩 Clang15            Pass: 100%/4   | Total:  2h 13m | Avg: 33m 24s | Max: 34m 26s | Hits:  56%/3416  
  🟩 Clang16            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 53s | Max: 34m 34s | Hits:  56%/3416  
  🟩 Clang17            Pass: 100%/26  | Total: 10h 38m | Avg: 24m 33s | Max: 36m 34s | Hits:  84%/21908 
  🟩 GCC6               Pass: 100%/2   | Total: 57m 57s | Avg: 28m 58s | Max: 29m 15s | Hits:  56%/1556  
  🟩 GCC7               Pass: 100%/6   | Total:  3h 04m | Avg: 30m 48s | Max: 32m 58s | Hits:  56%/4905  
  🟩 GCC8               Pass: 100%/6   | Total:  3h 13m | Avg: 32m 15s | Max: 34m 17s | Hits:  56%/4905  
  🟩 GCC9               Pass: 100%/6   | Total:  3h 14m | Avg: 32m 21s | Max: 38m 03s | Hits:  56%/4905  
  🟩 GCC10              Pass: 100%/4   | Total:  2h 27m | Avg: 36m 58s | Max: 40m 23s | Hits:  56%/3424  
  🟩 GCC11              Pass: 100%/7   | Total:  4h 40m | Avg: 40m 03s | Max: 48m 59s | Hits:  56%/5978  
  🟩 GCC12              Pass: 100%/4   | Total:  2h 22m | Avg: 35m 43s | Max: 36m 34s | Hits:  56%/3416  
  🟩 GCC13              Pass: 100%/28  | Total: 11h 14m | Avg: 24m 04s | Max: 40m 10s | Hits:  81%/23912 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 56m | Avg: 38m 49s | Max: 39m 43s | Hits:  56%/2340  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 46m 40s | Avg: 46m 40s | Max: 46m 40s | Hits:  60%/697   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 26m | Avg: 43m 09s | Max: 45m 16s | Hits:  60%/1394  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 14m | Avg: 44m 51s | Max: 47m 56s | Hits:  60%/2091  
🟩 cxx_family
  🟩 Clang              Pass: 100%/59  | Total:  1d 05h | Avg: 29m 35s | Max: 37m 17s | Hits:  68%/49906 
  🟩 GCC                Pass: 100%/63  | Total:  1d 07h | Avg: 29m 46s | Max: 48m 59s | Hits:  67%/53001 
  🟩 Intel              Pass: 100%/3   | Total:  1h 56m | Avg: 38m 49s | Max: 39m 43s | Hits:  56%/2340  
  🟩 MSVC               Pass: 100%/6   | Total:  4h 27m | Avg: 44m 35s | Max: 47m 56s | Hits:  60%/4182  
🟩 gpu
  🟩 v100               Pass: 100%/131 | Total:  2d 18h | Avg: 30m 34s | Max: 48m 59s | Hits:  67%/109429
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  2d 08h | Avg: 34m 04s | Max: 48m 59s | Hits:  56%/82101 
  🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 32m | Avg: 19m 01s | Max: 23m 43s | Hits:  99%/6832  
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 02m | Avg: 15m 19s | Max: 16m 55s | Hits:  99%/6832  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 23m | Avg: 17m 57s | Max: 18m 57s | Hits:  99%/6832  
  🟩 TestGPU            Pass: 100%/8   | Total:  3h 33m | Avg: 26m 43s | Max: 31m 41s | Hits:  99%/6832  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 17m | Avg: 45m 44s | Max: 48m 59s | Hits:  56%/2562  
  🟩 90a                Pass: 100%/4   | Total:  1h 14m | Avg: 18m 34s | Max: 19m 27s | Hits:  56%/3416  
🟩 std
  🟩 11                 Pass: 100%/34  | Total: 17h 02m | Avg: 30m 05s | Max: 48m 59s | Hits:  66%/28605 
  🟩 14                 Pass: 100%/37  | Total: 19h 19m | Avg: 31m 19s | Max: 47m 56s | Hits:  66%/30696 
  🟩 17                 Pass: 100%/36  | Total: 18h 34m | Avg: 30m 57s | Max: 46m 00s | Hits:  66%/29927 
  🟩 20                 Pass: 100%/24  | Total: 11h 49m | Avg: 29m 33s | Max: 43m 02s | Hits:  71%/20201

  • 🟩 thrust: Pass: 100%/118 | Total: 2d 08h | Avg: 28m 52s | Max: 1h 05m | Hits: 29%/138912

     
    🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total:  2d 04h | Avg: 28m 45s | Max:  1h 05m | Hits:  30%/129492
  🟩 arm64              Pass: 100%/8   | Total:  4h 03m | Avg: 30m 28s | Max: 35m 05s | Hits:  11%/9420  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 20m | Avg: 29m 20s | Max: 55m 49s | Hits:  11%/17660 
  🟩 11.8               Pass: 100%/3   | Total:  1h 56m | Avg: 38m 43s | Max: 42m 38s | Hits:  12%/3534  
  🟩 12.5               Pass: 100%/100 | Total:  1d 23h | Avg: 28m 30s | Max:  1h 05m | Hits:  32%/117718
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  1h 03m | Avg: 31m 34s | Max: 34m 02s | Hits:  11%/2354  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 20m | Avg: 29m 20s | Max: 55m 49s | Hits:  11%/17660 
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 56m | Avg: 38m 43s | Max: 42m 38s | Hits:  12%/3534  
  🟩 nvcc12.5           Pass: 100%/98  | Total:  1d 22h | Avg: 28m 27s | Max:  1h 05m | Hits:  32%/115364
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 03m | Avg: 31m 34s | Max: 34m 02s | Hits:  11%/2354  
  🟩 nvcc               Pass: 100%/116 | Total:  2d 07h | Avg: 28m 49s | Max:  1h 05m | Hits:  29%/136558
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  2h 50m | Avg: 28m 22s | Max: 32m 14s | Hits:  12%/7062  
  🟩 Clang10            Pass: 100%/3   | Total:  1h 35m | Avg: 31m 55s | Max: 35m 33s | Hits:  12%/3531  
  🟩 Clang11            Pass: 100%/4   | Total:  2h 04m | Avg: 31m 01s | Max: 33m 11s | Hits:  11%/4708  
  🟩 Clang12            Pass: 100%/4   | Total:  2h 07m | Avg: 31m 49s | Max: 36m 42s | Hits:  11%/4708  
  🟩 Clang13            Pass: 100%/4   | Total:  2h 00m | Avg: 30m 06s | Max: 31m 30s | Hits:  11%/4708  
  🟩 Clang14            Pass: 100%/4   | Total:  2h 01m | Avg: 30m 22s | Max: 32m 41s | Hits:  12%/4708  
  🟩 Clang15            Pass: 100%/4   | Total:  2h 10m | Avg: 32m 37s | Max: 37m 17s | Hits:  12%/4708  
  🟩 Clang16            Pass: 100%/4   | Total:  1h 59m | Avg: 29m 56s | Max: 31m 35s | Hits:  12%/4708  
  🟩 Clang17            Pass: 100%/18  | Total:  6h 30m | Avg: 21m 42s | Max: 34m 02s | Hits:  52%/21186 
  🟩 GCC6               Pass: 100%/2   | Total: 55m 03s | Avg: 27m 31s | Max: 30m 34s | Hits:  12%/2354  
  🟩 GCC7               Pass: 100%/6   | Total:  2h 51m | Avg: 28m 32s | Max: 32m 50s | Hits:  12%/7068  
  🟩 GCC8               Pass: 100%/6   | Total:  2h 49m | Avg: 28m 18s | Max: 31m 45s | Hits:  12%/7068  
  🟩 GCC9               Pass: 100%/6   | Total:  3h 02m | Avg: 30m 24s | Max: 34m 42s | Hits:  12%/7068  
  🟩 GCC10              Pass: 100%/4   | Total:  2h 07m | Avg: 31m 58s | Max: 36m 06s | Hits:  11%/4712  
  🟩 GCC11              Pass: 100%/7   | Total:  3h 49m | Avg: 32m 49s | Max: 42m 38s | Hits:  33%/8246  
  🟩 GCC12              Pass: 100%/4   | Total:  2h 13m | Avg: 33m 27s | Max: 37m 40s | Hits:  11%/4712  
  🟩 GCC13              Pass: 100%/20  | Total:  6h 34m | Avg: 19m 43s | Max: 35m 19s | Hits:  56%/23560 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 07m | Avg: 42m 31s | Max: 49m 31s | Hits:  12%/3540  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 55m 49s | Avg: 55m 49s | Max: 55m 49s | Hits:   9%/1173  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 56m | Avg: 58m 27s | Max: 59m 10s | Hits:   9%/2346  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  4h 02m | Avg: 40m 21s | Max:  1h 05m | Hits:  54%/7038  
🟩 cxx_family
  🟩 Clang              Pass: 100%/51  | Total: 23h 20m | Avg: 27m 27s | Max: 37m 17s | Hits:  26%/60027 
  🟩 GCC                Pass: 100%/55  | Total:  1d 00h | Avg: 26m 37s | Max: 42m 38s | Hits:  31%/64788 
  🟩 Intel              Pass: 100%/3   | Total:  2h 07m | Avg: 42m 31s | Max: 49m 31s | Hits:  12%/3540  
  🟩 MSVC               Pass: 100%/9   | Total:  6h 54m | Avg: 46m 05s | Max:  1h 05m | Hits:  39%/10557 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total:  2d 08h | Avg: 28m 52s | Max:  1h 05m | Hits:  29%/138912
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  2d 05h | Avg: 32m 13s | Max:  1h 05m | Hits:  15%/116553
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 46m | Avg:  9m 42s | Max: 20m 18s | Hits:  99%/12939 
  🟩 TestGPU            Pass: 100%/8   | Total:  1h 50m | Avg: 13m 48s | Max: 17m 55s | Hits:  99%/9420  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 56m | Avg: 38m 43s | Max: 42m 38s | Hits:  12%/3534  
  🟩 90a                Pass: 100%/4   | Total:  1h 16m | Avg: 19m 14s | Max: 21m 21s | Hits:  11%/4712  
🟩 std
  🟩 11                 Pass: 100%/30  | Total: 11h 57m | Avg: 23m 55s | Max: 35m 07s | Hits:  28%/35328 
  🟩 14                 Pass: 100%/34  | Total: 17h 20m | Avg: 30m 36s | Max: 57m 45s | Hits:  27%/40020 
  🟩 17                 Pass: 100%/33  | Total: 17h 16m | Avg: 31m 23s | Max:  1h 05m | Hits:  28%/38847 
  🟩 20                 Pass: 100%/21  | Total: 10h 12m | Avg: 29m 10s | Max:  1h 04m | Hits:  35%/24717

  • 🟩 pycuda: Pass: 100%/1 | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 ctk
  🟩 12.5               Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 cudacxx
  🟩 nvcc12.5           Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 10m 45s | Avg: 10m 45s | Max: 10m 45s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
pycuda

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- pycuda

🏃‍ Runner counts (total jobs: 250)
# Runner
178 linux-amd64-cpu16
41 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

miscco
miscco approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@bernhardmgruber bernhardmgruber merged commit 53fe08f into NVIDIA:main Jul 23, 2024
266 checks passed
@bernhardmgruber bernhardmgruber deleted the pointer_traits branch July 23, 2024 07:15
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Aug 4, 2024
@bernhardmgruber @pciolkosz
Simplify some pointer traits (NVIDIA#2020)
ec3f842
pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Aug 4, 2024
@bernhardmgruber @pciolkosz
Simplify some pointer traits (NVIDIA#2020)
a81077f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
thrust For all items related to Thrust.
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @miscco