Factor out build job logic into a "run-as-coder" reusable workflow. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Jul 12, 2023
| image: ${{inputs.build_image}} | ||
| command: | | ||
| ${{ inputs.build_script }} "${{inputs.compiler_exe}}" "${{inputs.std}}" "${{inputs.gpu_build_archs}}" | ||
|
|
||
| test: | ||
| needs: build | ||
| if: ${{ !cancelled() && ( needs.build.result == 'success' || needs.build.result == 'skipped' ) && inputs.test_script != '' && inputs.test_image != '' && inputs.run_tests}} |
There was a problem hiding this comment.
No change requested.
I am wondering whether we could add another result to the build step, that checks whether we had a 100% sccache hit rate. In that case we can omit running the test step
There was a problem hiding this comment.
Maybe we can store it in an environment variable
miscco
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #204
Factors out the logic for cloning the cccl repo into the
/home/coder/cccldirectory and executing a command as the coder user into a reusable workflow.Checklist