Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nvcc-specific matrix. #243

Merged
merged 34 commits into from
Jul 26, 2023

Conversation

jrhemstad
Copy link
Collaborator

@jrhemstad jrhemstad commented Jul 18, 2023

Description

closes #240

Adds a nvcc: field under the pull-request field of matrix.yaml in preperation for adding other nested fields for other kinds of jobs under pull-request.

Updates the compute-matrix job to use a compute-matrix.sh script to make it easier to test locally. Also updated the job itself to extract an nvcc-specific matrix.

  • Add nvcc field to matrix.yaml
  • Refactor compute-matrix logic into bash script
  • Refactor compute-matrix workflow into composite action
  • Update compute-matrix job to invoke compute-matrix composite action
  • Update compute-matrix job to compute the NVCC specific matrix attributes like PER_CUDA_COMPILER as further post-processing after invoking the composite action

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jrhemstad jrhemstad requested review from a team as code owners July 18, 2023 19:35
@jrhemstad jrhemstad requested review from jarmak-nv and gevtushenko and removed request for a team July 18, 2023 19:35
@jrhemstad jrhemstad marked this pull request as draft July 18, 2023 19:47
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that compute-matrix action works fine, but I'm unable to find where PER_CUDA_COMPILER_MATRIX, CUDA_VERSIONS etc. are in it's output.

@jrhemstad
Copy link
Collaborator Author

I can see that compute-matrix action works fine, but I'm unable to find where PER_CUDA_COMPILER_MATRIX, CUDA_VERSIONS etc. are in it's output.

Yeah, it's still in progress 🙂. I forgot to open the PR as a draft and so it assigned reviewers. When I converted it back to a draft, it didn't clear the reviewers.

You can hold off on reviewing until I convert it back to ready for review.

@jrhemstad jrhemstad marked this pull request as ready for review July 20, 2023 21:05
@miscco miscco added feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure labels Jul 24, 2023
@jrhemstad jrhemstad merged commit 3ed55e5 into NVIDIA:main Jul 26, 2023
368 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make current matrix work nested under nvcc field
3 participants