-
Notifications
You must be signed in to change notification settings - Fork 285
Prefix CUB kernel headers with kernel_
#6383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix CUB kernel headers with kernel_
#6383
Conversation
This comment has been minimized.
This comment has been minimized.
c2eda2d to
8b5c2fa
Compare
This comment has been minimized.
This comment has been minimized.
8b5c2fa to
4471123
Compare
This comment has been minimized.
This comment has been minimized.
4471123 to
df1c24a
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not in favor given that we already have /kernels/meow.cuh
kernel/kernel_meow..cuh feels like an unnecessary overkill
We already have: I would agree with your reasoning in isolation. But with the status quo, the kernel headers just violate the established convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me ;)
df1c24a to
e049dc2
Compare
e049dc2 to
8ed6ef2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This makes the filenames more consistent with the rest of CUB
8ed6ef2 to
311eb9e
Compare
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 12h 09m: Pass: 100%/86 | Total: 2d 17h | Max: 3h 15m | Hits: 90%/73464See results here. |
This makes the filenames more consistent with the rest of CUB