Skip to content

Conversation

@bernhardmgruber
Copy link
Contributor

This makes the filenames more consistent with the rest of CUB

@bernhardmgruber bernhardmgruber requested review from a team as code owners October 29, 2025 20:21
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 29, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 29, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favor given that we already have /kernels/meow.cuh

kernel/kernel_meow..cuh feels like an unnecessary overkill

@github-project-automation github-project-automation bot moved this from In Review to In Progress in CCCL Nov 3, 2025
@bernhardmgruber
Copy link
Contributor Author

I am not in favor given that we already have /kernels/meow.cuh

kernel/kernel_meow..cuh feels like an unnecessary overkill

We already have:
agent/agent_meow.cuh
block/block_meow.cuh
device/device_meow.cuh
device/dispatch/dispatch_meow.cuh
device/dispatch/tuning/tuning_meow.cuh
grid/grid_meow.cuh
thread/thread_meow.cuh
warp/warp_meow.cuh

I would agree with your reasoning in isolation. But with the status quo, the kernel headers just violate the established convention.

Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me ;)

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Nov 3, 2025
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) November 3, 2025 14:57
@bernhardmgruber bernhardmgruber enabled auto-merge (squash) November 3, 2025 14:57
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

This makes the filenames more consistent with the rest of CUB
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🥳 CI Workflow Results

🟩 Finished in 12h 09m: Pass: 100%/86 | Total: 2d 17h | Max: 3h 15m | Hits: 90%/73464

See results here.

@bernhardmgruber bernhardmgruber merged commit 2791207 into NVIDIA:main Nov 4, 2025
192 of 195 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 4, 2025
@bernhardmgruber bernhardmgruber deleted the rename_kernel_headers branch November 4, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants