Skip to content

Conversation

@charan-003
Copy link
Contributor

@charan-003 charan-003 commented Oct 30, 2025

Thrust Range-Based Algorithm Implementation Checklist (C++23) based on https://en.cppreference.com/w/cpp/algorithm.html

<algorithm> Header

Search

  • search(...)

Implements only the search algorithm for now #5160

@charan-003 charan-003 requested a review from a team as a code owner October 30, 2025 06:56
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 30, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 30, 2025
@gonidelis
Copy link
Member

Is this PR intended to check all the boxes? If not (hopefully) you can just leave the algorithm(s) that is intended to work on and we can add a link to the EPIC issue. Keep in mind of the PR size - reviewability inverse proportionality theorem if you plan to add more.

@bernhardmgruber
Copy link
Contributor

@charan-003 thank you for trying to contribute to CCCL! Could you pleaes focus on one algorithm at a time, so we have an easier time reviewing? Thx!

@charan-003 charan-003 changed the title Add missing Thrust algorithms Add missing Thrust Search algorithms Nov 2, 2025
@charan-003
Copy link
Contributor Author

@charan-003 thank you for trying to contribute to CCCL! Could you pleaes focus on one algorithm at a time, so we have an easier time reviewing? Thx!

@gonidelis @bernhardmgruber
Thanks for the suggestion! I’ll focus on the search algorithms in this PR and create a new one for the other algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants