Skip to content

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Oct 30, 2025

This moves the internal libcu++ configuration into its own file

It also splits some of the configurations for e.g thread API and atomimcs into their own file

@miscco miscco requested review from a team as code owners October 30, 2025 10:44
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 30, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 30, 2025
@miscco miscco requested a review from wmaxey October 30, 2025 10:45
@miscco miscco force-pushed the move_libcudacxx_config branch 4 times, most recently from 1c86928 to 52e47ab Compare October 30, 2025 14:37
Copy link
Contributor

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake + infra (c2h) lgtm

Copy link
Contributor

@fbusato fbusato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a more detailed description next time. We cannot review 1000+ files.

@oleksandr-pavlyk
Copy link
Contributor

One of the modified files, python/cuda_cccl/build.log, file was first added by @shwina in 3f37825. What purpose does it serve in the repo?

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Python perspective.

@github-actions

This comment has been minimized.

@miscco miscco force-pushed the move_libcudacxx_config branch from 52e47ab to 22b4f2b Compare November 3, 2025 14:15
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the move_libcudacxx_config branch from 22b4f2b to 021e912 Compare November 4, 2025 08:03
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the move_libcudacxx_config branch from 021e912 to 5f8ec0e Compare November 4, 2025 18:56
@davebayer
Copy link
Contributor

pre-commit.ci autofix

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

This comment has been minimized.

@miscco miscco force-pushed the move_libcudacxx_config branch from d6fe9b3 to 012fd06 Compare November 5, 2025 07:56
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the move_libcudacxx_config branch from 012fd06 to 58ebc9d Compare November 5, 2025 12:02
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🥳 CI Workflow Results

🟩 Finished in 6h 06m: Pass: 100%/90 | Total: 2d 18h | Max: 3h 13m | Hits: 61%/218544

See results here.

@davebayer davebayer merged commit 3ce0945 into NVIDIA:main Nov 5, 2025
201 of 204 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 5, 2025
@miscco miscco deleted the move_libcudacxx_config branch November 5, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants