Replace _CCCL_HAS_CUDA_COMPILER() with _CCCL_CUDA_COMPILATION()
#6399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Oct 30, 2025
This comment has been minimized.
This comment has been minimized.
fbusato
approved these changes
Oct 30, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
replace_has_cuda_compiler
branch
from
7dd693d to
37bc668
Compare
davebayer
force-pushed
the
replace_has_cuda_compiler
branch
from
37bc668 to
2a83d85
Compare
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 8h 18m: Pass: 100%/209 | Total: 3d 18h | Max: 2h 41m | Hits: 99%/379546See results here. |
miscco
reviewed
Nov 5, 2025
| #endif // no system header | ||
|
|
||
| #if _CCCL_HAS_CUDA_COMPILER() | ||
| #if _CCCL_CUDA_COMPILATION() |
There was a problem hiding this comment.
I observe that this is not changing the comment at the end of the block, please adopt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we used to use
_CCCL_HAS_CUDA_COMPILER()to check whether we are compiling a CUDA source file, which is not what_CCCL_HAS_CUDA_COMPILER()actually does. I've replaced the use with mostly_CCCL_CUDA_COMPILATION().Please, carefully check whether I didn't do a mistake :)