Skip to content

Conversation

@RAMitchell
Copy link
Contributor

@RAMitchell RAMitchell commented Oct 30, 2025

Description

closes
Part of #5679

Update linear_congruential_generator with constexpr, stream operators, tests and a fast discard operator for common parameters.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Oct 30, 2025
@RAMitchell RAMitchell marked this pull request as ready for review October 31, 2025 10:16
@RAMitchell RAMitchell requested a review from a team as a code owner October 31, 2025 10:16
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Oct 31, 2025
Copy link
Contributor

@fbusato fbusato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
just a couple of nits

{
(void) operator()();
// minstd_rand and minstd_rand0 can use this efficient implementation
uint64_t __acc_mult = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

::cuda::std::uint64_t or better in this case using ::cuda::std::uint64_t;

@github-project-automation github-project-automation bot moved this from In Review to In Progress in CCCL Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants