-
Notifications
You must be signed in to change notification settings - Fork 285
Add cccl_add_xfail_compile_target_test CMake function
#6434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
- CUB's usages of XFAIL compilation are updated to use the new utility. - test_device_segment_reduce_offset_type_fail test is fixed; the regexes weren't detected and some cases were failing for unintended reasons. - test_param_general_fail is added to test edge case.
2c01365 to
038b9cf
Compare
|
/ok to test |
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
1701cc1 to
2748bfa
Compare
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 8h 20m: Pass: 100%/263 | Total: 1d 08h | Max: 30m 27s | Hits: 99%/380769See results here. |
| using OutputTupleT = detail::non_void_value_t<OutputIteratorT, KeyValuePair<OffsetT, InputValueT>>; | ||
| using OutputKeyT = typename OutputTupleT::Key; | ||
| using OutputValueT = typename OutputTupleT::Value; | ||
| using AccumT = OutputTupleT; | ||
| using InitT = detail::reduce::empty_problem_init_t<AccumT>; | ||
|
|
||
| static_assert(::cuda::std::is_same_v<int, OutputKeyT>, "Output key type must be int."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elstehle does the output iterator's value type's key really have to be int or can it be another integral type (a larger offset type)? The documentation for OutputIteratorT says int.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I originally tried is_convertible to int, but the compilation fails farther in if this isn't exactly int. The new static assert just gives a nicer error message that we can consistently check with the fail test.
Supports CUB-style in-source error regex extraction as defined the docs: