Implement the new tuning API for DeviceRadixSort
#6767
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
changed the title
DeviceRadixSort
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
from
d16f5b0 to
3263d2c
Compare
miscco
approved these changes
Nov 25, 2025
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
I love how much this cleans everything up
Comment on lines
+134
to
+176
| _CCCL_API constexpr friend bool | ||
| operator!=(const radix_sort_histogram_policy& lhs, const radix_sort_histogram_policy& rhs) | ||
| { | ||
| return !(lhs == rhs); | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick: We could guard all operator!= on #if _CCCL_STD_VER <= 2017
Contributor
Author
There was a problem hiding this comment.
Or we just wait until C++20 and refactor.
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
from
66dfd43 to
b0fe51f
Compare
10 tasks
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
2 times, most recently
from
0d56d8d to
56c437d
Compare
Contributor
Author
|
/ok to test 56c437d |
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
from
c583277 to
172c115
Compare
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
3 times, most recently
from
8ad87dc to
800b936
Compare
Contributor
Author
|
/ok to test 800b936 |
This comment has been minimized.
This comment has been minimized.
30 tasks
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
from
800b936 to
7e722a2
Compare
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 7e722a2 |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test 6cefe64 |
bernhardmgruber
force-pushed
the
tuning_radix_sort
branch
from
6cefe64 to
74089a2
Compare
Contributor
Author
|
/ok to test 74089a2 |
Contributor
😬 CI Workflow Results🟥 Finished in 2h 21m: Pass: 66%/93 | Total: 1d 18h | Max: 1h 27m | Hits: 92%/74580See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
cub.test.device.radix_sort_keys.lid_0.key_bits_16passesif constexpron the onesweep algorithm in the dispatcherpolicy_selector_from_hub_policyFixes: #6676