-
Notifications
You must be signed in to change notification settings - Fork 325
mdspan to DLPack
#7027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,391
−2
Merged
mdspan to DLPack
#7027
Changes from 11 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
750ca5a
first version
fbusato f040c10
add unit test
fbusato 464ccc2
documentation
fbusato 6f32ae9
Update libcudacxx/include/cuda/__mdspan/mdspan_to_dlpack.h
fbusato 3457d3a
Merge branch 'mdspan-to-dlpack' of github.com:fbusato/cccl into mdspa…
fbusato ee05eda
add many types
fbusato 4d2e0da
remove operator->
fbusato f290320
formatting
fbusato 7a22848
fix MSVC warning
fbusato f78db30
improve documentation
fbusato 1467ab2
fix MSVC warning
fbusato 136ab59
refactor vector type traits by removing conditional compilation for v…
fbusato 501f48c
reenable vector types for CTK 13
fbusato bd6094c
Merge branch 'main' into mdspan-to-dlpack
fbusato 604257d
fix msvc warning
fbusato eb2635a
fix index_operator.pass
fbusato 8e813f1
Merge branch 'main' into mdspan-to-dlpack
fbusato b6a52cd
use internal type
fbusato 0f8d8b7
Merge branch 'main' into mdspan-to-dlpack
fbusato 87b6777
address comments from #7047
fbusato d6b5dcb
use CCCL_DISABLE_DLPACK
fbusato ced0dcd
Merge branch 'main' into mdspan-to-dlpack
fbusato ddb3a13
use _CCCL_HAS_DLPACK
fbusato c27bcbd
add negative test
fbusato b2ef919
handle deprecated warnings
fbusato c3e1a58
Merge branch 'main' into mdspan-to-dlpack
fbusato 27c7329
add lifetimebound
fbusato 810585d
address comments
fbusato cac4960
fix unit tests
fbusato 4a4117d
simplify __dlpack_tensor
fbusato 93d4321
use cuda::std::array
fbusato 2524f46
fix compile error
fbusato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
docs/libcudacxx/extended_api/mdspan/mdspan_to_dlpack.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| .. _libcudacxx-extended-api-mdspan-mdspan-to-dlpack: | ||
|
|
||
| ``mdspan`` to DLPack | ||
| ==================== | ||
|
|
||
| This functionality provides a conversion from ``cuda::host_mdspan``, ``cuda::device_mdspan``, and ``cuda::managed_mdspan`` to `DLPack <https://dmlc.github.io/dlpack/latest/>`__ ``DLTensor`` view. | ||
|
|
||
| Defined in the ``<cuda/mdspan>`` header. | ||
|
|
||
| Conversion functions | ||
| -------------------- | ||
|
|
||
| .. code:: cuda | ||
|
|
||
| namespace cuda { | ||
|
|
||
| template <typename T, typename Extents, typename Layout, typename Accessor> | ||
| [[nodiscard]] dlpack_tensor<Extents::rank()> | ||
| to_dlpack(const cuda::host_mdspan<T, Extents, Layout, Accessor>& mdspan); | ||
|
|
||
| template <typename T, typename Extents, typename Layout, typename Accessor> | ||
| [[nodiscard]] dlpack_tensor<Extents::rank()> | ||
| to_dlpack(const cuda::device_mdspan<T, Extents, Layout, Accessor>& mdspan, | ||
| cuda::device_ref device = cuda::device_ref{0}); | ||
|
|
||
| template <typename T, typename Extents, typename Layout, typename Accessor> | ||
| [[nodiscard]] dlpack_tensor<Extents::rank()> | ||
| to_dlpack(const cuda::managed_mdspan<T, Extents, Layout, Accessor>& mdspan); | ||
|
|
||
| } // namespace cuda | ||
|
|
||
| Types | ||
| ----- | ||
|
|
||
| .. code:: cuda | ||
|
|
||
| namespace cuda { | ||
|
|
||
| template <size_t Rank> | ||
| class dlpack_tensor { | ||
| public: | ||
| dlpack_tensor(); | ||
| dlpack_tensor(const dlpack_tensor&) noexcept; | ||
| dlpack_tensor(dlpack_tensor&&) noexcept; | ||
| dlpack_tensor& operator=(const dlpack_tensor&) noexcept; | ||
| dlpack_tensor& operator=(dlpack_tensor&&) noexcept; | ||
| ~dlpack_tensor() noexcept = default; | ||
|
|
||
| DLTensor& get() noexcept; | ||
| const DLTensor& get() const noexcept; | ||
| }; | ||
|
|
||
| } // namespace cuda | ||
|
|
||
| ``cuda::dlpack_tensor`` stores a ``DLTensor`` and owns the backing storage for its ``shape`` and ``strides`` pointers. The class does not use any heap allocation. | ||
|
|
||
| .. note:: **Lifetime** | ||
|
|
||
| The ``DLTensor`` associated with ``cuda::dlpack_tensor`` must not outlive the wrapper. If the wrapper is destroyed, the returned ``DLTensor::shape`` and ``DLTensor::strides`` pointers will dangle. | ||
|
|
||
| .. note:: **Const-correctness** | ||
|
|
||
| ``DLTensor::data`` points at ``mdspan.data_handle()`` (or is ``nullptr`` if ``mdspan.size() == 0``). If ``T`` is ``const``, the pointer is ``const_cast``'d because ``DLTensor::data`` is unqualified. | ||
|
|
||
| Semantics | ||
| --------- | ||
|
|
||
| The conversion produces a non-owning DLPack view of the ``mdspan`` data and metadata: | ||
|
|
||
| - ``DLTensor::ndim`` is ``mdspan.rank()``. | ||
| - For rank > 0, ``DLTensor::shape[i]`` is ``mdspan.extent(i)``. | ||
| - For rank > 0, ``DLTensor::strides[i]`` is ``mdspan.stride(i)``. | ||
| - ``DLTensor::byte_offset`` is always ``0``. | ||
| - ``DLTensor::device`` is: | ||
|
|
||
| - ``{kDLCPU, 0}`` for ``cuda::host_mdspan`` | ||
| - ``{kDLCUDA, device.get()}`` for ``cuda::device_mdspan`` | ||
| - ``{kDLCUDAManaged, 0}`` for ``cuda::managed_mdspan`` | ||
|
|
||
| Element types are mapped to ``DLDataType`` according to the DLPack conventions, including: | ||
|
|
||
| - ``bool``. | ||
| - Signed and unsigned integers. | ||
| - IEEE-754 Floating-point and extended precision floating-point, including ``__half``, ``__nv_bfloat16``, ``__float128``, FP8, FP6, FP4 when available. | ||
| - Complex: ``cuda::std::complex<__half>``, ``cuda::std::complex<float>``, and ``cuda::std::complex<double>``. | ||
| - `CUDA built-in vector types <https://docs.nvidia.com/cuda/cuda-programming-guide/05-appendices/cpp-language-extensions.html#built-in-types>`__, such as ``int2``, ``float4``, etc. | ||
| - Vector types for extended floating-point, such as ``__half2``, ``__nv_fp8x4_e4m3``, etc. | ||
|
|
||
| Constraints | ||
| ----------- | ||
|
|
||
| - The accessor ``data_handle_type`` must be a pointer type. | ||
|
|
||
| Runtime errors | ||
| -------------- | ||
|
|
||
| - If any ``extent(i)`` or ``stride(i)`` cannot be represented in ``int64_t``, the conversion raises an exception. | ||
|
|
||
| Availability notes | ||
| ------------------ | ||
|
|
||
| - This API is available only when DLPack header is present, namely ``<dlpack/dlpack.h>`` is found in the include path. | ||
|
|
||
| References | ||
| ---------- | ||
|
|
||
| - `DLPack C API <https://dmlc.github.io/dlpack/latest/c_api.html>`__ documentation. | ||
|
|
||
| Example | ||
| ------- | ||
|
|
||
| .. code:: cuda | ||
|
|
||
| #include <dlpack/dlpack.h> | ||
| #include <cuda/mdspan> | ||
| #include <cuda/std/cassert> | ||
| #include <cuda/std/cstdint> | ||
|
|
||
| int main() { | ||
| using extents_t = cuda::std::extents<size_t, 2, 3>; | ||
|
|
||
| int data[6] = {0, 1, 2, 3, 4, 5}; | ||
| cuda::host_mdspan<int, extents_t> md{data, extents_t{}}; | ||
|
|
||
| auto dl = cuda::to_dlpack(md); | ||
| const auto& dltensor = dl.get(); | ||
|
|
||
| // `dl` owns the shape/stride storage; `dltensor.data` is a non-owning pointer to `data`. | ||
| assert(dltensor.device.device_type == kDLCPU); | ||
| assert(dltensor.ndim == 2); | ||
| assert(dltensor.shape[0] == 2 && dltensor.shape[1] == 3); | ||
| assert(dltensor.strides[0] == 3 && dltensor.strides[1] == 1); | ||
| assert(dltensor.data == data); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.