Add NVRTC compatibility errors to CUB headers #7079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1 task
hzaidi05
changed the title
bernhardmgruber
approved these changes
Jan 5, 2026
Contributor
bernhardmgruber
left a comment
bernhardmgruber
left a comment
There was a problem hiding this comment.
LGTM, just one suggestion
|
|
||
| #include <cub/config.cuh> | ||
|
|
||
| #ifndef CCCL_DISABLE_CUB_NVRTC_COMPATIBILITY_CHECK |
Contributor
There was a problem hiding this comment.
Suggestion: Let's generalize the suppression macro:
Suggested change
| #ifndef CCCL_DISABLE_CUB_NVRTC_COMPATIBILITY_CHECK | |
| #ifndef CCCL_DISABLE_NVRTC_COMPATIBILITY_CHECK |
We may want to apply this to other places well.
Please rename all occurences.
Author
There was a problem hiding this comment.
Sounds good to me, renamed the macro now
Contributor
|
/ok to test 09dc4c1 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
😬 CI Workflow Results🟥 Finished in 1d 12h: Pass: 97%/95 | Total: 5d 10h | Max: 6h 00m | Hits: 67%/96396See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5405
#6035 added an NVRTC-specific diagnostic to the CUB umbrella header (
cub/cub.cuh), but confusing NVRTC compilation failures can still occur when including other public CUB headers that are incompatible with NVRTC. This PR extends similar diagnostics to additional public CUB headers that rely on host-side functionality and are therefore unsupported when compiling with NVRTC.Checklist