[libcu++] Check if managed pools are accessible in is_pointer_accessible test #7096
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pciolkosz
force-pushed
the
check_device_attributes_before_using_managed_pools_in_is_pointer_accessible_test
branch
from
44ff7f0 to
5d41894
Compare
miscco
approved these changes
Jan 7, 2026
davebayer
approved these changes
Jan 7, 2026
davebayer
reviewed
Jan 7, 2026
libcudacxx/test/libcudacxx/cuda/memory/is_pointer_accessible.pass.cpp
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
…_pools_in_is_pointer_accessible_test
fbusato
approved these changes
Jan 7, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miscco
approved these changes
Jan 8, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 16h 09m: Pass: 100%/91 | Total: 1d 04h | Max: 1h 22m | Hits: 98%/218937See results here. |
Contributor
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
…ble test (#7096) * Check if managed pools are accessible in is_pointer_accessible test * Apply suggestion from @davebayer --------- Co-authored-by: David Bayer <[email protected]> (cherry picked from commit a6b5490)
miscco
pushed a commit
that referenced
this pull request
Jan 8, 2026
…ble test (#7096) (#7116) * Check if managed pools are accessible in is_pointer_accessible test * Apply suggestion from @davebayer --------- (cherry picked from commit a6b5490) Co-authored-by: pciolkosz <[email protected]> Co-authored-by: David Bayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_pointer_accessible test uses managed memory pools without checking if they are supported, this PR adds the required device attribute checks.
It also does a fly-by fix of
__deviceGetAttributeaccidentally returningCUdeviceinstead ofint