Skip to content

[Backport branch/3.2.x] Fix calculation of necessary bits in feistel projection #7117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miscco merged 2 commits into from
Jan 8, 2026
Merged

[Backport branch/3.2.x] Fix calculation of necessary bits in feistel projection #7117

miscco merged 2 commits into from
Jan 8, 2026

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2026

Description

Backport of #7098 to branch/3.2.x.

@miscco @github-actions
Fix calculation of necessary bits in feistel projection (#7098)
1db8550 
We incorrectly used `bit_ceil` which gave us the next power of two not the number of bits we need to represent the number of elements.
Use `bit_width` instead

Fixes #7073

(cherry picked from commit 1b37e20)
@github-actions github-actions bot requested a review from a team as a code owner January 8, 2026 08:05
@github-actions github-actions bot requested a review from fbusato January 8, 2026 08:05
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jan 8, 2026
@github-actions github-actions bot mentioned this pull request Jan 8, 2026
Merged
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 8, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco
Copy link
Contributor

miscco commented Jan 8, 2026

/ok to test 59fc9ce

@github-project-automation github-project-automation bot moved this from Todo to In Review in CCCL Jan 8, 2026
@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 8, 2026

🥳 CI Workflow Results

🟩 Finished in 1h 36m: Pass: 100%/90 | Total: 1d 07h | Max: 1h 32m | Hits: 89%/215984

See results here.

@miscco miscco merged commit 4e3450f into branch/3.2.x Jan 8, 2026
103 checks passed
@miscco miscco deleted the backport-7098-to-branch/3.2.x branch January 8, 2026 12:09
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miscco miscco miscco approved these changes

@fbusato fbusato Awaiting requested review from fbusato fbusato is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees

No one assigned

Labels

None yet

Projects

CCCL
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miscco