cub, c.parallel: change {lower,upper}_bound to return indices. #7320
+22
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
NaderAlAwar
approved these changes
Jan 22, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 16h 24m: Pass: 100%/93 | Total: 4d 20h | Max: 5h 28m | Hits: 74%/91833See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7007, introducing {lower,upper}_bound to CUB and c.parallel, made them return iterators in the output buffer; the idea was to be more consistent with the standard algorithms. However, the Thrust approach of returning indices is probably more useful, as the input range is already required to be random access.
Closes #7258
Checklist